feat: [IPR-1063] Add locale to editor state props #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const locale = detectLocale(Object.keys(locales)); | ||
|
|
||
| let locale = 'en'; | ||
| if (params.locale && Object.keys(locales).includes(params.locale)) { |
There was a problem hiding this comment.
I remember we talked about having a console.warn if Object.keys(locales).includes(params.locale) is false.
There was a problem hiding this comment.
I forgot about it. Will add it
georgyangelov
approved these changes
Sep 23, 2025
KManolov3
approved these changes
Sep 24, 2025
Test report for scratch-vm 1 files ±0 770 suites ±0 1m 5s ⏱️ ±0s Results for commit a28aa46. ± Comparison against base commit 38044f4. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
georgyangelov
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
IPR-1063
Proposed Changes
Add locale to the editor state params that is passed from NGP. If such is not passed keep the old old approach of getting locale