Change setup.py #755
Change setup.py #755
Conversation
setup.py
Outdated
| @@ -44,14 +44,12 @@ | |||
| license="BSD", | |||
| zip_safe=False, | |||
| keywords='dateparser', | |||
| python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*', | |||
| python_requires='!=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*', | |||
| classifiers=[ | |||
| 'Development Status :: 2 - Pre-Alpha', | |||
There was a problem hiding this comment.
I have just realized that we are in "Pre-Alpha" status.... 🤔
We should probably update this to be Development Status :: 4 - Beta or Development Status :: 5 - Production/Stable @Gallaecio let me know your thoughts.
There was a problem hiding this comment.
I'm not totally confident in moving it to "Production/Stable" because of the "multiple thread" issues: #441
There was a problem hiding this comment.
I’m not sure whether or not multithreading support should be a requirement for Dateparser to be considered stable, but I think it makes sense to delay that tag until Dateparser 1.0 is released.
There was a problem hiding this comment.
@Gallaecio hmmm.. but these changes are performed to release that 1.0.0 version, so in that case, it makes sense to change it now. right?
There was a problem hiding this comment.
Oh, I forgot 1.0 was the next version! In that case, I would go for that tag, yes. Stable does not mean feature-complete. It’s production-ready for people that do not need multiprocessing support.
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 304 304
Lines 2632 2632
=======================================
Hits 2506 2506
Misses 126 126 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @kishan3, thank you for submitting this PR.
Could you also remove this line: 'Programming Language :: Python :: Implementation :: PyPy'? (as we are deprecating PyPy).
You should also update the install_requires. Now it should be:
install_requires=[
'python-dateutil',
'pytz',
# https://bitbucket.org/mrabarnett/mrab-regex/issues/314/import-error-no-module-named
'regex !=2019.02.19',
'tzlocal',
],
Based on the recent feedback from @lopuhin, I would wait on this. It’s starting to look to me like we may support the latest PyPy. |
|
@kishan3 , so we will be waiting to clarify the PyPy decision before proceeding. If you want you can check this list: https://pypi.org/classifiers/ to see if there is something useful that we could add in the setup file. |
setup.py
Outdated
| @@ -44,14 +44,12 @@ | |||
| license="BSD", | |||
| zip_safe=False, | |||
| keywords='dateparser', | |||
| python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*', | |||
| python_requires='!=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*', | |||
There was a problem hiding this comment.
| python_requires='!=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*', | |
| python_requires='>=3.5', |
However, as the next month Python 3.5 will be deprecated, I think we will be supporting only Python > 3.6. If that's the case, we will need to remove also the 'Programming Language :: Python :: 3.5', line.
There was a problem hiding this comment.
Hi @kishan3 !
as mentioned here, we will drop the support for PyPy, so you can do what I mentioned here: #755 (review) (removing the PyPy line and changing the install_requires).
|
Hi @noviluni Thanks for the feedback! I have updated the setup.py file as per your suggestion. |
|
Hi @kishan3, thanks! but you have to remove this line too: |
|
Sorry @noviluni I somehow missed it. It is removed now. |
For #727