Skip to content

Use bulleted list for resources #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025
Merged

Conversation

toshi38
Copy link
Contributor

@toshi38 toshi38 commented Jun 3, 2025

What is the motivation?

The docs where hard to read when type, class, id, params where on one line. Other areas and annotations use bullet points so standardize to that.

image

What does this change do?

Fix markdown with missing bullet points, so it doesn't run the field descriptions across one line when rendered.

What is your testing strategy?

Trivial change to docs, didn't test aside from reviewing code.

Is this related to any issues?

No

Have you read the Contributing Guidelines?

Fix markdown with missing bullet points, so it doesn't run the field descriptions across one line when rendered.

Signed-off-by: Stephen Lau <[email protected]>
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and the fix, much appreciated!

I just requested 2 small changes, this will be ready to be merged then, thanks!

This will do something like this:
image

mathieu-benoit and others added 2 commits June 3, 2025 11:47
Standardize on similar style to `service` and `containers` sections.

Co-authored-by: Mathieu Benoit <[email protected]>
Signed-off-by: Stephen Lau <[email protected]>
@mathieu-benoit mathieu-benoit self-requested a review June 4, 2025 10:11
@mathieu-benoit mathieu-benoit self-requested a review June 4, 2025 10:19
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mathieu-benoit mathieu-benoit merged commit db83d39 into score-spec:main Jun 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants