-
Notifications
You must be signed in to change notification settings - Fork 16
Score example hub #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Score example hub #179
Conversation
…t 928f47e git-subtree-dir: gen/external-repos/score-spec/examples git-subtree-split: 928f47e08f163943f7ba153938b64513a781e237
…nal-repos/score-spec/examples'
…tent Signed-off-by: Tobias Babin <[email protected]>
4fc9628
to
f4c526f
Compare
Signed-off-by: Tobias Babin <[email protected]>
…ent from commit 6a20bf3 git-subtree-dir: gen/external-repos/score-spec/community-provisioners git-subtree-split: 6a20bf34acc2a7dcaf261357f2ff781f2054b3c0
…nal-repos/score-spec/community-provisioners' Signed-off-by: Tobias Babin <[email protected]>
Signed-off-by: Tobias Babin <[email protected]>
Signed-off-by: Tobias Babin <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Santiago Beroch <[email protected]>
Signed-off-by: Mathieu Benoit <[email protected]>
Signed-off-by: Mathieu Benoit <[email protected]>
Great stuff in there, thanks @sberoch! Just did some tests, so sharing and capturing some screenshots here. ![]() ![]() ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super great, thanks!
I have some comments that require some updates please, captured while I was testing this PR:
-
yarn run dprint check
was failing, I needed to fix the CI by running and commitingyarn fmt
here 99b825d, is it something that could be fixed in the script generating these files? -
When running
yarn run hugo server
, we are getting this new warningWARN calling IsSet with unsupported type "invalid" (<nil>) will always return false.
, could we fix this? -
I'm seeing a new behavior when opening the website, in the navigation panel on the left, all the menu items are expanded by default, it was not the case before. Only the one with the focus, when we click on it, was expanded. Is that on-purpose or could we get back to the previous behavior?
-
When clicking on
Service
under theResources
section and not theSpecification
section, it's actually showing theService
from theSpecification
section:

- Apparently some of the info and actions in the header were lost? See in this screenshot where we see the
4 min read
and all the actions on the top right corner (View page source
, Edit this page`, etc.), could we have them back please?

- Apparently some of the info in the footer were lost too? See in this screenshot where we see the
Last modified June 4, 2025...
and the email, twitter, github, slack icons:

-
For any Score file when clicking on
(view on GitHub)
we are getting a404
because landing to https://github.com/score-spec/examples/blob/main/score/specification/ instead of https://github.com/score-spec/examples/blob/main/specification/ -
The style around the tabs seems bit different from what we have today (round corner, tab selected with pink border), could we be consistent here and have the same style as before? See here:

- I'm seeing a styling issue on this page, seeing this now (grey + link, but text not visible):

Awesome @sberoch , thanks a lot! I also tested the pages and found just these items to look at, adding on to @mathieu-benoit 's findings. All test URLs referring to running the site locally.
I actually cannot reproduce it, works as expected in my local site.
@mathieu-benoit Can you double-check
This example correctly shows the example files in the
If I temporarily add them here manually and re-generate the site, they are displayed, but then the examples files are not shown anymore. Desired state: the README content plus the example files are shown.
Can we have the search bar while in the examples section? It is currently not shown.
|
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
These changes will introduce a "Score example hub" to help users of Score find ready-to-use examples already available in other Score repos like the Score examples more easily and at a central place.
This PR covers the first iteration of the example hub to integrate examples for core Score usage. Future PRs will add Resource provisioners and Patch templates.
What does this change do?
This change
What is your testing strategy?
main
only before merging.Is this related to any issues?
No.
Have you read the Contributing Guidelines?