Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nix Flake #4

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Nix Flake #4

wants to merge 7 commits into from

Conversation

justDeeevin
Copy link

The previous commit claiming to add NixOS support merely added a devshell. This flake fully packages Scope, in addition to providing a development shell. A NixOS user (with a flake config) can now install the app seamlessly.
The package includes a desktop shortcut. The keywords list in the shortcut has been left empty--I felt it more appropriate for one of you to decide upon fitting keywords.

@justDeeevin
Copy link
Author

Additional note: Right now the Desktop Icon is being pulled directly from this org's github avatar. It might be preferable to include the file in this repo or someplace more reliable.

flake.nix Show resolved Hide resolved
@alii alii added the help wanted Extra attention is needed label Nov 16, 2024
@alii
Copy link
Contributor

alii commented Nov 16, 2024

Thanks for this, just added this 'help wanted' label so someone else (@bvvst or @zarc probably) could add keywords.

I'm not super familiar with Flake (I've only used it once before) so couldn't really give this PR a review of much value. How could I test this PR locally so we can merge it?

@vmfunc
Copy link
Contributor

vmfunc commented Nov 16, 2024

I'm not super familiar with Flake (I've only used it once before) so couldn't really give this PR a review of much value. How could I test this PR locally so we can merge it?

run it under a docker container

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@vmfunc vmfunc added the chore edits to the workflow label Nov 18, 2024
@justDeeevin justDeeevin force-pushed the flake branch 2 times, most recently from 6f199e7 to 8dacf4c Compare November 18, 2024 13:42
@justDeeevin
Copy link
Author

Building but not currently running on my machine... seems like a wayland thing, though.
image
Don't think this is a blocker to this PR, but still worth mentioning.

@circularsprojects
Copy link
Contributor

Building but not currently running on my machine... seems like a wayland thing, though.

not really sure why it wouldn't work on wayland, it builds and runs completely fine for me on wayland (although i dont use nixos, i use endeavour)

@justDeeevin
Copy link
Author

justDeeevin commented Nov 18, 2024

Now that you mention it, I realize it's probably a me problem. I've run into that same error message with WezTerm as well, but only on my laptop. So it's probably something I'm messing up with my graphics config on here.

@vmfunc
Copy link
Contributor

vmfunc commented Nov 21, 2024

any updates on this PR?

@justDeeevin
Copy link
Author

The desktop entry needs some keywords added. Also apparently some merge conflicts? Resolving now.

@justDeeevin
Copy link
Author

I can't think of anything else that's been asked of me yet. Once we come up with some keywords for the desktop entry, it should be ready to merge.

@justDeeevin
Copy link
Author

justDeeevin commented Nov 21, 2024

Looking at some example in nixpkgs:
Vesktop uses the keywords: ["discord" "vencord" "electron" "chat"]
Discord has no keywords.
They both also use the categories ["Network" "InstantMessaging"]. Vesktop also includes the category "Chat"

Perhaps no keywords, just the three categories that Vesktop falls under? That would look like

categories = [
  "Network"
  "InstantMessaging"
  "Chat"
];

I'm hesitant to make this call myself since this isn't my app.

@Sanae6
Copy link
Contributor

Sanae6 commented Dec 4, 2024

we should just go with ["discord", "chat"] for keywords, and the same categories that Vesktop uses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore edits to the workflow help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants