test(pytest): skip instead of xfail where appropriate#1619
Open
scop wants to merge 1 commit into
Open
Conversation
scop
commented
Apr 19, 2026
Skipping is appropriate for cases where there's no point in running the tests for some reason we can detect, whereas expecting failure is more like a TODO thing -- known bug or a missing feature. Ref https://docs.pytest.org/en/stable/how-to/skipping.html This only addresses pytest.mark.xfail/skipif, not our pytest.mark.complete skipif=/xfail=.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping is appropriate for cases where there's no point in running the tests for some reason we can detect, whereas expecting failure is more like a TODO thing -- known bug or a missing feature.
Ref https://docs.pytest.org/en/stable/how-to/skipping.html
This only addresses pytest.mark.xfail/skipif for now, not yet our pytest.mark.complete skipif=/xfail= (there's a lot of that in the tree).