October 28, 2023: Merge with PS part 2 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help differentiate local teams and remote-loaded teams. When they're initially requested, the client now compares each new team against all the existing teams - if they appear to be similar, it doesn't add it to the builder (so that dupe teams don't show up). It considers them similar if they have the same mons, title, and format. Otherwise, if it finds one that's close, it'll add it but marked as (server version) so people can tell which is which.
* Overhaul the format selector to be more easily used * Update js/client-mainmenu.js Co-authored-by: Kris Johnson <[email protected]> * Lower search pop open limit --------- Co-authored-by: Kris Johnson <[email protected]>
This bug hasn't been noticed because the two main uses of battle frames (the sim itself, and Replays) both absolutely position battle frames, so they have nothing "below" them. But on downloaded replays, on screens smaller than 640px across, they took up an incorrect height. This is also relevant to New Replays. This commit fixes that.
Unfortunately, the my computer crashed, and took with it the PSD for this updated logo. But fortunately, I managed to upload all the important versions (like the orange version for "you have a notification").
By default, buttons on mobile wait 300ms (to see if you're double tapping) before they register as pressed. Adding `touch-action: manipulation` prevents this delay, at the cost of not being able to zoom in when double-tapping a button, which I'm sure no one has ever tried to do.
Now that fc00e68 has made the Seeking screen more common, it's worth making it more readable.
They now support small windows/screens and dark mode.
It's cluttering this code a lot for no reason.
In the distant past, Lobby was open by default, so people linking to Lobby usually meant to link to PS itself, so links to Lobby would just open PS. This is no longer necessary, now that we no longer open Lobby by default. This commit also cleans up a bunch of other .htaccess entries, for style/readability.
This has been sitting around uncommitted in the client. I'm sure someone knows what's up with this, but I don't.
New Replays isn't done yet but I've done a lot of work on it and probably it deserves a commit. Why rewrite Replays: - I redesigned pokemonshowdown.com to look more modern and support dark mode, and rejiggering Old Replays would be a lot of work anyway. - It'd be nice to actually deploy some of PS's whole Preact infrastructure somewhere, instead of it just being in development hell. - Nice to get a second look at the relevant code, leading to fixes like fc00e68 and f28b1e9. - Replays is due for a migration from JS/PHP to TS anyway. Anyway, feel free to try out New Replays, it's live in: https://pokemonshowdown.com/replays/ Old Replays will stick around until we hit feature parity, but that shouldn't be too long (I know, famous last words).
The main difference is that the main search screen should look much nicer now. https://pokemonshowdown.com/replays/ Putting search/featured/recent in separate sections makes the new design look much nicer. And dark mode is now fully supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.