chore: switch pkg/ code to murfffi/gorich #53
Conversation
murfffi/gorich was bootstrapped with a copy of the code in pkg/ Removing the pkg/ code makes it easier to release a stable version, by reducing the public API.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @murfffi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses a housekeeping chore by switching the internal pkg/ code to use murfffi/gorich. The murfffi/gorich repository was bootstrapped with a copy of the code in pkg/. Removing the pkg/ code reduces the public API, which should make it easier to release a stable version.
Highlights
- Dependency Update: The
go.modandgo.sumfiles are updated to includegithub.com/murfffi/gorich v0.1.0as a dependency and the go version is updated from 1.23.0 to 1.23.8. - Code Migration: Multiple files under
internal/are modified to import packages fromgithub.com/murfffi/gorichinstead ofgithub.com/sclgo/usqlgen/pkg/. This includessclerr,lang, andfipackages. - Package Removal: The
pkg/fi,pkg/lang, andpkg/sclerrdirectories are removed, as their functionality is now provided by themurfffi/gorichdependency.
Changelog
Click here to see the changelog
- go.mod
- Updated go version from 1.23.0 to 1.23.8
- Added dependency on github.com/murfffi/gorich v0.1.0
- go.sum
- Added checksums for github.com/murfffi/gorich v0.1.0
- internal/gen/dbmgr_test.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/sclerrwithgithub.com/murfffi/gorich/sclerr - Reordered imports for better readability
- Replaced import of
- internal/gen/gen.go
- Replaced imports of
github.com/sclgo/usqlgen/pkg/langandgithub.com/sclgo/usqlgen/pkg/sclerrwithgithub.com/murfffi/gorich/langandgithub.com/murfffi/gorich/sclerr
- Replaced imports of
- internal/gen/gen_test.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/fiwithgithub.com/murfffi/gorich/fi
- Replaced import of
- internal/gen/unzip.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/sclerrwithgithub.com/murfffi/gorich/sclerr
- Replaced import of
- internal/integrationtest/build_test.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/fiwithgithub.com/murfffi/gorich/fi
- Replaced import of
- internal/integrationtest/clickhouse/clickhouse_test.go
- Replaced imports of
github.com/sclgo/usqlgen/pkg/fiandgithub.com/sclgo/usqlgen/pkg/sclerrwithgithub.com/murfffi/gorich/fiandgithub.com/murfffi/gorich/sclerr - Reordered imports for better readability
- Replaced imports of
- internal/integrationtest/cosmos/cosmos_test.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/fiwithgithub.com/murfffi/gorich/fi
- Replaced import of
- internal/integrationtest/databend/databend_test.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/fiwithgithub.com/murfffi/gorich/fi
- Replaced import of
- internal/integrationtest/impala/impala_test.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/fiwithgithub.com/murfffi/gorich/fi
- Replaced import of
- internal/integrationtest/monetdb/monetdb_test.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/fiwithgithub.com/murfffi/gorich/fi
- Replaced import of
- internal/shell/cmd_build.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/sclerrwithgithub.com/murfffi/gorich/sclerr
- Replaced import of
- internal/shell/cmd_build_test.go
- Replaced import of
github.com/sclgo/usqlgen/pkg/fiwithgithub.com/murfffi/gorich/fi
- Replaced import of
- pkg/fi/assume.go
- File deleted
- pkg/fi/must.go
- File deleted
- pkg/fi/must_test.go
- File deleted
- pkg/lang/lang.go
- File deleted
- pkg/sclerr/sclerr.go
- File deleted
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A module's cleanup,
A smaller API's gleam,
Stable release nears.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes the pkg/ code and switches to using the murfffi/gorich package. This is a good change as it reduces the public API and makes it easier to release a stable version. The changes look good overall.
Merge Readiness
The code changes look good and the pull request is ready to be merged. I am unable to approve the pull request, and recommend that users have others review and approve this code before merging.
| "reflect" | ||
| "testing" | ||
|
|
||
| "github.com/murfffi/gorich/sclerr" | ||
| "github.com/sclgo/usqlgen/internal/gen" | ||
| "github.com/stretchr/testify/require" |
There was a problem hiding this comment.
The import statements have been reordered. While this isn't necessarily an issue, it might be helpful to group them logically (e.g., standard library, third-party, internal) for better readability.
import (
"context"
"database/sql"
"errors"
"fmt"
"reflect"
"testing"
"github.com/stretchr/testify/require"
"github.com/murfffi/gorich/sclerr"
"github.com/sclgo/usqlgen/internal/gen"
// drivers
_ "github.com/mithrandie/csvq-driver"
_ "modernc.org/sqlite"
)
murfffi/gorich was bootstrapped with a copy of the code in pkg/ Removing the pkg/ code makes it easier to release a stable version, by reducing the public API.