fix: adding event query if start_at is null or not started#5
Merged
Conversation
Collaborator
|
After testing, already-started events still show up in the report. It seems now_rows in _send_report_for_channel is not filtering by the slugs passed in via event_map. |
iefiru
reviewed
Jul 12, 2026
Collaborator
There was a problem hiding this comment.
Here the UPDATE sets last_reported_at for all events in the channel, including already-started ones. How about filtering by the slugs already passed in via event_map, and reusing the now timestamp from send_report() instead of calling utcnow_iso() again?
Collaborator
Author
There was a problem hiding this comment.
Thank you @iefiru, I've pushed the commit per your input.
…ring Co-authored-by: iefiru <7875793+iefiru@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is what I fixed from #4, I found the event query is lack of time statement, please review this change.