Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper: Cyanobacteria detection in small, inland water bodies with CyFi #936

Merged
merged 29 commits into from
Sep 25, 2024

Conversation

ejm714
Copy link
Contributor

@ejm714 ejm714 commented Jun 7, 2024

NOTE: The title in my talk is "Using Satellite Imagery to Identify Harmful Algal Blooms and Protect Public Health".

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Amey Ambade @ameyxd

Reviewers:

@ameyxd ameyxd self-assigned this Jun 8, 2024
@ameyxd ameyxd added the paper This indicates that the PR in question is a paper label Jun 8, 2024
Copy link

github-actions bot commented Jun 10, 2024

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/emily_dorne 🔍 Inspect 88 checks passed (12 optional) Aug 23, 2024, 10:16 PM

@ameyxd ameyxd removed their assignment Jun 11, 2024
@ameyxd
Copy link
Contributor

ameyxd commented Jun 20, 2024

Review reminders sent to @anivorlis @rcjackson

Copy link
Collaborator

@rcjackson rcjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very well written paper that shows how a ML-based package for identifying cyanobacteria blooms in satellite imagery can be easily deployed for use by public health officials. The idea of the community model competition shows an excellent example of how the open source community can come together to build quality ML models. I had a few small comments, but overall I would recommend for publication.

papers/emily_dorne/main.md Outdated Show resolved Hide resolved
papers/emily_dorne/main.md Outdated Show resolved Hide resolved
papers/emily_dorne/main.md Outdated Show resolved Hide resolved
papers/emily_dorne/main.md Outdated Show resolved Hide resolved
papers/emily_dorne/main.md Show resolved Hide resolved
@ejm714
Copy link
Contributor Author

ejm714 commented Jun 21, 2024

Thanks for the review @rcjackson! I'll leave some comments in response to yours and will also take a pass at incorporating this information into the paper

ejm714 and others added 2 commits June 27, 2024 11:01
* clarify train/test splits

* note on decimal degrees

* note on california

* tweaks

* clarify ordering

* move things to footnote

* additional specificity on feature processing

* add note on stratified k folds

* explain stratified group k fold use

* move to better section

* copy edits

* tweak

---------

Co-authored-by: Katie Wetstone <[email protected]>
@ejm714
Copy link
Contributor Author

ejm714 commented Jun 27, 2024

Paper has been updated to address @rcjackson's review comments

@cbcunc cbcunc requested a review from John-Drake July 13, 2024 23:06
Copy link
Collaborator

@John-Drake John-Drake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this work has been a real pleasure to read. The ingenuity of hosting a competition to generate models, which helped guide the final architecture of CyFi, is remarkable. Additionally, a model was produced that competes well against CyAN, and incorporated into a package that installed flawlessly and provided great visualizations.

My only concerns are minor and aimed at helping readers outside of this field (such as myself) and assisting those who will later attempt to improve on CyFi. I hope these comments are well received and wish the authors the best.

papers/emily_dorne/main.md Show resolved Hide resolved
papers/emily_dorne/main.md Show resolved Hide resolved
papers/emily_dorne/main.md Show resolved Hide resolved
papers/emily_dorne/main.md Outdated Show resolved Hide resolved
papers/emily_dorne/main.md Outdated Show resolved Hide resolved
papers/emily_dorne/main.md Show resolved Hide resolved
papers/emily_dorne/main.md Show resolved Hide resolved
papers/emily_dorne/main.md Show resolved Hide resolved
papers/emily_dorne/main.md Show resolved Hide resolved
papers/emily_dorne/main.md Show resolved Hide resolved
@ameyxd
Copy link
Contributor

ameyxd commented Jul 30, 2024

@ejm714 - please review and update acc to reviewer 2's comments.

@ameyxd
Copy link
Contributor

ameyxd commented Aug 6, 2024

@ejm714 - please review and update acc to reviewer 2's comments.

@ejm714 - reminder to respond and update your submission ASAP.

@ejm714
Copy link
Contributor Author

ejm714 commented Aug 6, 2024

@ameyxd Thanks for the ping. I was out of the office last week (immediately after I received the second review on Friday). I replied to the proceedings email to let folks know I'll have my edits in by Aug 14

klwetstone and others added 4 commits August 22, 2024 15:54
* small review edits

* add performance breakdowns

* add stats from CA data

* add chlorophyl-a note

* train set size note

* less specific footnote

* add kw orcid

* update author info

* clarify chlorophyll

* update decision tree paragraph and add footnote with links to other competitions

* typo

* wording tweaks

* remove callout for B02 b/c we need to update that image

* move conda note to footnote since this is likely only temporary

* remove image (see reviewer comment response) + clarify cali table languagae

* format

* edits

* add winners announcement

* update links

* add train set size

* update dataframe

* update footnote numbers

* minor tweaks

* typo

---------

Co-authored-by: ejm714 <[email protected]>
@ejm714
Copy link
Contributor Author

ejm714 commented Aug 22, 2024

@John-Drake Thanks so much for the thoughtful review! All comments should now be addressed. Please see the latest edits. There was only one suggestion we didn't include and I left a rationale in the unresolved comment.

P.S. Great meeting you at the conference 😄

* copy edit

* wording edits

* edits

* concluding sentence

* tweak

* clarify cyanobacteria index

* remove extra word
@ejm714
Copy link
Contributor Author

ejm714 commented Aug 23, 2024

@ameyxd just letting you know my edits are complete

@cbcunc cbcunc merged commit b73e393 into scipy-conference:2024 Sep 25, 2024
4 checks passed
@ameyxd
Copy link
Contributor

ameyxd commented Sep 25, 2024

@rcjackson @John-Drake - apologies for late notice here, but can you review the authors final edits and give a thumbs up?

@John-Drake
Copy link
Collaborator

John-Drake commented Sep 25, 2024

@rcjackson @John-Drake - apologies for late notice here, but can you review the authors final edits and give a thumbs up?

The paper is well written and interesting. The authors have done a wonderful job at addressing any comments/questions/concerns. Thumbs up all the way.

@rcjackson
Copy link
Collaborator

@rcjackson @John-Drake - apologies for late notice here, but can you review the authors final edits and give a thumbs up?

Emily did a great job here! Thumbs up from me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper This indicates that the PR in question is a paper ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants