Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper: THEIA: An Offline Tool for Tradespace Visualization #920

Merged
merged 15 commits into from
Sep 25, 2024

Conversation

samuelcwilliams
Copy link
Contributor

@samuelcwilliams samuelcwilliams commented May 31, 2024

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Hongsup Shin @hongsupshin

Reviewers:

@stevejpurves

This comment has been minimized.

@cbcunc cbcunc added the paper This indicates that the PR in question is a paper label May 31, 2024
Copy link

github-actions bot commented Jun 4, 2024

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/theia 🔍 Inspect 37 checks passed (7 optional) Jul 22, 2024, 4:57 PM

@ameyxd
Copy link
Contributor

ameyxd commented Jun 4, 2024

@samuelcwilliams thanks for the submission! Can you add the DOI for plotly? We can run the checks again after.

you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:

error_rules:
  - rule: doi-exists
    severity: ignore
    keys:
      - abc
      - def01

@ameyxd ameyxd self-assigned this Jun 4, 2024
@samuelcwilliams
Copy link
Contributor Author

@ameyxd, I followed Plotly citation guidance found here, and it didn't include a DOI, so I set it to ignore.

@ameyxd
Copy link
Contributor

ameyxd commented Jun 4, 2024

thanks @samuelcwilliams cheers.

@ameyxd ameyxd removed their assignment Jun 11, 2024
papers/theia/mybib.bib Outdated Show resolved Hide resolved
papers/theia/main.md Outdated Show resolved Hide resolved
papers/theia/main.md Outdated Show resolved Hide resolved
papers/theia/main.md Outdated Show resolved Hide resolved
@mihaimaruseac
Copy link
Collaborator

Overall, this looks good, but I think it would be even more useful if you can show how the data listed at the beginning of the paper is processed to produce the screenshots at the end. Does the user have to type code? If yes, can you include the code? If not, can you then show how this will work with a more complex data type?

@samuelcwilliams
Copy link
Contributor Author

@mihaimaruseac I made some small changes and added in some new content regarding the data upload process and the details on the screenshots in the paper. Let me know if you think there are any areas I should expand on. I appreciate all the feedback!

Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

papers/theia/main.md Outdated Show resolved Hide resolved
@tkoyama010 tkoyama010 self-requested a review July 13, 2024 17:04
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The logic of this paper itself seems perfect to me. I just didn't quite understand background what Tradespace meant. I would like you to explain in more detail what kind of data you are trying to process.

@tkoyama010
Copy link
Member

tkoyama010 commented Jul 14, 2024

I'm sorry, I closed the PR by mistake.

@tkoyama010 tkoyama010 closed this Jul 14, 2024
@tkoyama010 tkoyama010 reopened this Jul 14, 2024
@cbcunc cbcunc requested a review from tkoyama010 July 14, 2024 23:46
@tkoyama010
Copy link
Member

Thank you. The logic of this paper itself seems perfect to me. I just didn't quite understand background what Tradespace meant. I would like you to explain in more detail what kind of data you are trying to process.

@cbcunc I already finished review :)

@samuelcwilliams
Copy link
Contributor Author

@tkoyama010, I added in some additional details on what tradespace data is. I tried to be concise, as I tend to ramble on sometimes. Let me know of any additional edits that come to mind!

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@hongsupshin
Copy link
Contributor

Thanks @tkoyama010 @mihaimaruseac @ssuzana for reviewing the paper!

@cbcunc cbcunc merged commit 8932fbb into scipy-conference:2024 Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper This indicates that the PR in question is a paper ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants