Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper: Mamba Models a replacement for Transformers? #917

Merged
merged 53 commits into from
Sep 25, 2024

Conversation

JaynouOliver
Copy link
Contributor

@JaynouOliver JaynouOliver commented May 31, 2024

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Meghann Agarwal @mepa

Reviewers:

JaynouOliver and others added 30 commits May 20, 2024 10:24
Signed-off-by: saike148 <[email protected]>
added key differences and updated the equation formatting
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great paper. State-space models are something I have used in my own career and I am amazed that they can be applied in this way. Is it possible to share the URL of the GitHub repository you used for this model in this paper? I am sure it would be even better if you could share it so we can actually implement this idea.

@JaynouOliver
Copy link
Contributor Author

I can share the code written originally by the authors of MAMBA https://github.com/state-spaces/mamba
Just wanted to check with you before I finally commit the changes

@tkoyama010
Copy link
Member

tkoyama010 commented Jun 24, 2024

Thanks, I was making that statement based on the fact that SciPy papers often emphasize being able to run the code and reproduce it. Do I need to run both Transformer and mamba to understand the results of this paper?

I think this paper could be an excellent introduction to mamba. To that end, I think it would be good to add a link to it appropriately (including Transformers) :)

@JaynouOliver
Copy link
Contributor Author

Sure I can add those links in the paper. I will make these changes right away.

@JaynouOliver
Copy link
Contributor Author

@tkoyama010 please add any further changes if needed after review.

papers/Suvrakamal_Das/mybib.bib Outdated Show resolved Hide resolved
@mepa
Copy link
Member

mepa commented Jun 28, 2024

Hi @tkoyama010 and @HaoZeke! In case a little extra time is needed, the initial complete review deadline has been extended to next Wednesday, July 3rd.

@tkoyama010
Copy link
Member

Hi @tkoyama010 and @HaoZeke! In case a little extra time is needed, the initial complete review deadline has been extended to next Wednesday, July 3rd.

Yes please. Thanks!

@JaynouOliver
Copy link
Contributor Author

JaynouOliver commented Jun 30, 2024

@tkoyama010 please add any further changes if needed after review.

Hi @tkoyama010, all working and good!

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@JaynouOliver
Copy link
Contributor Author

JaynouOliver commented Aug 4, 2024

Hi everyone @tkoyama010 @HaoZeke @ameyxd @mepa ,

I hope you’re all doing well. If there are any additional suggestions, feedback, or corrections needed before the author revision period ends on August 7th, please let me know. I’d be happy to make the necessary changes and incorporate your feedback.

Thank you very much!

@mepa
Copy link
Member

mepa commented Sep 2, 2024

Hi @tkoyama010 and @HaoZeke - Do you feel that this paper is ready for inclusion in the Proceedings?

@tkoyama010, I see that you have approved the PR so will assume "yes" unless I hear otherwise.

Thanks for reviewing!

@tkoyama010
Copy link
Member

Yes! I am ready for it.

Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@HaoZeke
Copy link
Member

HaoZeke commented Sep 2, 2024 via email

@JaynouOliver
Copy link
Contributor Author

Thanks a lot @tkoyama010 and @HaoZeke for the approval!!

@mepa
Copy link
Member

mepa commented Sep 2, 2024

Thanks very much for reviewing, @tkoyama010 and @HaoZeke.

@cbcunc cbcunc merged commit b4b456a into scipy-conference:2024 Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper This indicates that the PR in question is a paper ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants