-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper: Improving Code Quality with Array and DataFrame Type Hints #906
Conversation
Curvenote Preview
|
I have read this paper thrice and cannot find any issue with it. It's well-written, so easy to follow and builds a narrative in an excellent manner. Some Minor Suggestions (can be ignored):
Overall, a well-written article. Not only, I have learnt new things, but also enjoyed reading it with its smooth style. |
Many thanks, @EngineerKhan , for your suggestions and feedback. |
@flexatone Glad to review your paper and nice to meet you! Just a quick intro: I got introduced to the open source community during my time at makepath a geospatial data science company that maintains several open source packages and I'm involved with Project Bokeh (as much as time allows). Recently, I started working for a process engineering company that isn't involved in the open source community so volunteering with SciPy gives me a small way to stay involved! |
Thanks for the interesting paper. I think it's worth mentioning how these issues are handled (or not) with TensorFlow and Pandas. |
Many thanks, @cdlindsey , for your feedback. I have added a small section describing how these issues are handled in PyTorch, TensorFlow, and Pandas. |
If you are creating this PR in order to submit a draft of your paper, please name your PR with
Paper: <title>
. An editor will then add apaper
label and GitHub Actions will be run to check and build your paper.See the project readme for more information.
Editor: Charles Lindsey @cdlindsey
Reviewers: