allow to enable sanitizer for any OPT type

- there is no real reason to allow this for dbg only
- just having it disabled for opt builds by default is important, but
  it is disabled always now by default anyway
- fix default in docu

Author: svigerske

INSTALL.md

@@ -340,7 +340,7 @@ In your SCIP main directory, enter `make [options]` with the following options:
 | `OSTYPE`              | `[linux, darwin, cygwin, irix, windows, mingw]` | the operating system: try to autedetect                               |
 | `PAPILO=false`        | `[false, true]`      | to disable or disable the MILP presolver based on the presolving library PaPILO                  |
 | `READLINE=true`       | `[true, false]`      | to enable or disable readline library for interactive shell                                      |
-| `SANITIZE=true`       | `[true, false, thread, address, memory]` | sanitizers to enable: SANITIZE not set to false enables undefined-behavior sanitizer, SANITIZE=thread enables thread sanitizer, SANITIZE=address enables address sanitizer, SANITIZE=memory enables memory sanitizer (clang only); only used if OPT=dbg |
+| `SANITIZE=false`      | `[true, false, thread, address, memory]` | sanitizers to enable: SANITIZE not set to false enables undefined-behavior sanitizer, SANITIZE=thread enables also thread sanitizer, SANITIZE=address enables also address sanitizer, SANITIZE=memory enables also memory sanitizer (clang only); Linux clang/gcc only |
 | `SHARED=false`        | `[false, true]`      | to suppress or create shared libraries (only Gnu compiler)                                       |
 | `SYM=none`            | `[none, nauty, snauty, bliss, sbliss, dejavu]` | to choose method for computing symmetries in mixed nonlinear integer programs                  |
 | `TPI=none`            | `[none, omp, tny]`   | to disable the task processing interface or use it with the openmp or tinycthreads interface for concurrent solves |

make/make.linux.clang

@@ -24,3 +24,32 @@ ifeq ($(SHARED),true)
 FLAGS		+=	-fPIC
 endif
 LINK_shared		=	-shared
+
+# Enable sanitizers (http://clang.llvm.org/docs/UsersManual.html#controlling-code-generation).
+
+# enable ThreadSanitizer (http://clang.llvm.org/docs/ThreadSanitizer.html)
+ifeq ($(SANITIZE),thread)
+  SANITIZERFLAGS = -g -fsanitize=thread
+endif
+
+# enable AddressSanitizer (http://clang.llvm.org/docs/AddressSanitizer.html)
+ifeq ($(SANITIZE),address)
+  SANITIZERFLAGS = -g -fsanitize=address
+endif
+
+# enable MemorySanitizer (http://clang.llvm.org/docs/MemorySanitizer.html)
+ifeq ($(SANITIZE),memory)
+  SANITIZERFLAGS = -g -fsanitize=memory
+endif
+
+# UndefinedBehaviorSanitizer if SANITIZE is true, thread, address, or memory
+ifneq ($(filter $(SANITIZE),true thread address memory),)
+  SANITIZERFLAGS += -g -fsanitize=undefined -fsanitize=float-cast-overflow -fsanitize=float-divide-by-zero
+endif
+
+CFLAGS += $(SANITIZERFLAGS)
+CXXFLAGS += $(SANITIZERFLAGS)
+LDFLAGS += $(SANITIZERFLAGS)
+ifeq ($(SHARED),true)
+  LIBBUILDFLAGS += $(SANITIZERFLAGS)
+endif

make/make.linux.clang.dbg

@@ -2,32 +2,3 @@ FLAGS		+=	-DSCIP_ROUNDING_FE
 OFLAGS		+=	-O0 -g
 CFLAGS		+=	$(GCCWARN)
 CXXFLAGS	+=	$(GXXWARN)
-
-# Enable sanitizers (http://clang.llvm.org/docs/UsersManual.html#controlling-code-generation).
-
-# enable ThreadSanitizer (http://clang.llvm.org/docs/ThreadSanitizer.html)
-ifeq ($(SANITIZE),thread)
-  SANITIZERFLAGS = -fsanitize=thread
-endif
-
-# enable AddressSanitizer (http://clang.llvm.org/docs/AddressSanitizer.html)
-ifeq ($(SANITIZE),address)
-  SANITIZERFLAGS = -fsanitize=address
-endif
-
-# enable MemorySanitizer (http://clang.llvm.org/docs/MemorySanitizer.html)
-ifeq ($(SANITIZE),memory)
-  SANITIZERFLAGS = -fsanitize=memory
-endif
-
-# UndefinedBehaviorSanitizer if SANITIZE is true, thread, address, or memory
-ifneq ($(filter $(SANITIZE),true thread address memory),)
-  SANITIZERFLAGS += -fsanitize=undefined -fsanitize=float-cast-overflow -fsanitize=float-divide-by-zero
-endif
-
-CFLAGS += $(SANITIZERFLAGS)
-CXXFLAGS += $(SANITIZERFLAGS)
-LDFLAGS += $(SANITIZERFLAGS)
-ifeq ($(SHARED),true)
-  LIBBUILDFLAGS += $(SANITIZERFLAGS)
-endif

make/make.linux.gnu

@@ -16,3 +16,29 @@ ifeq ($(SHARED),true)
 FLAGS		+=	-fPIC
 endif
 LINK_shared		=	-shared
+
+# ThreadSanitizer (https://github.com/google/sanitizers/wiki/ThreadSanitizerCppManual)
+ifeq ($(SANITIZE),thread)
+  SANITIZERFLAGS = -g -fsanitize=thread
+endif
+
+# AddressSanitizer (https://github.com/google/sanitizers/wiki/AddressSanitizer)
+ifeq ($(SANITIZE),address)
+  SANITIZERFLAGS = -g -fsanitize=address
+endif
+
+ifeq ($(SANITIZE),memory)
+  $(warning Memory Sanitizer not available with GCC)
+endif
+
+# UndefinedBehaviorSanitizer if SANITIZE is true, thread, address, or memory
+ifneq ($(filter $(SANITIZE),true thread address memory),)
+  SANITIZERFLAGS += -g -fsanitize=undefined -fsanitize=float-cast-overflow -fsanitize=float-divide-by-zero
+endif
+
+CFLAGS += $(SANITIZERFLAGS)
+CXXFLAGS += $(SANITIZERFLAGS)
+LDFLAGS += $(SANITIZERFLAGS)
+ifeq ($(SHARED),true)
+  LIBBUILDFLAGS += $(SANITIZERFLAGS)
+endif

make/make.linux.gnu.dbg

@@ -2,29 +2,3 @@ FLAGS		+=	-DSCIP_ROUNDING_FE
 OFLAGS		+=	-O0 -g
 CFLAGS		+=	$(GCCWARN) -funit-at-a-time
 CXXFLAGS	+=	$(GXXWARN) -funit-at-a-time
-
-# ThreadSanitizer (https://github.com/google/sanitizers/wiki/ThreadSanitizerCppManual)
-ifeq ($(SANITIZE),thread)
-  SANITIZERFLAGS = -fsanitize=thread
-endif
-
-# AddressSanitizer (https://github.com/google/sanitizers/wiki/AddressSanitizer)
-ifeq ($(SANITIZE),address)
-  SANITIZERFLAGS = -fsanitize=address
-endif
-
-ifeq ($(SANITIZE),memory)
-  $(warning Memory Sanitizer not available with GCC)
-endif
-
-# UndefinedBehaviorSanitizer if SANITIZE is true, thread, address, or memory
-ifneq ($(filter $(SANITIZE),true thread address memory),)
-  SANITIZERFLAGS += -fsanitize=undefined -fsanitize=float-cast-overflow -fsanitize=float-divide-by-zero
-endif
-
-CFLAGS += $(SANITIZERFLAGS)
-CXXFLAGS += $(SANITIZERFLAGS)
-LDFLAGS += $(SANITIZERFLAGS)
-ifeq ($(SHARED),true)
-  LIBBUILDFLAGS += $(SANITIZERFLAGS)
-endif