allow to enable sanitizer for any build type

- there is no real reason to allow this for debug only
- just having it disabled for release builds by default is important, but
  it is disabled always now by default anyway

Author: svigerske

CMakeLists.txt

@@ -86,7 +86,7 @@ option(NOBLKBUFMEM "should block and buffer memory be disabled" OFF)
 option(NOBLKMEM "should block memory be disabled" OFF)
 option(NOBUFMEM "should buffer memory be disabled" OFF)
 option(DEBUGSOL "should the debug solution mechanism be enabled" OFF)
-option(SANITIZE "should sanitizers be enabled in debug mode if available" OFF)
+option(SANITIZE "should sanitizers be enabled if available" OFF)
 option(COVERAGE "enable coverage support" OFF)
 SET(COVERAGE_CTEST_ARGS "" CACHE STRING "additional ctest arguments for coverage")
 option(MT "use static runtime libraries for Visual Studio compiler" OFF)

INSTALL.md

@@ -199,7 +199,7 @@ e.g., `cmake </path/to/SCIP> -DSOPLEX_DIR=<path/to/SoPlex/build/or/install>`.
 | `NOBLKBUFMEM`          | `on`, `off`                        | `NOBLKBUFMEM=[true,false]` |                                                                    |
 | `MT`                   | `on`, `off`                        |                            | use static runtime libraries for Visual Studio compiler on Windows |
 | `THREADSAFE`           | `on`, `off`                        | `THREADSAFE=[true,false]`  | thread safe compilation                                            |
-| `SANITIZE`             | `on`, `off`, `thread`, `address`, `memory` | `SANITIZE=...`     | sanitizers to enable if available and debug mode; if not `off`, then enables undefined-behavior sanitizer, `thread` enables thread sanitizer, `address` enables address sanitizer, `memory` enables memory sanitizer |
+| `SANITIZE`             | `on`, `off`, `thread`, `address`, `memory` | `SANITIZE=...`     | sanitizers to enable; if not `off` (default), then enables undefined-behavior sanitizer, `thread` enables also thread sanitizer, `address` enables also address sanitizer, `memory` enables also memory sanitizer |
 | `TPI`                  | `tny`, `omp`, `none`               | `TPI=[tny,omp,none]`       | enable task processing interface required for concurrent solver    |
 
 Parameters can be set all at once or in subsequent calls to `cmake` - extending or modifying the existing configuration.

cmake/Modules/FindMSan.cmake

@@ -33,13 +33,13 @@ if(${SANITIZE} STREQUAL "memory")
         message(WARNING "MemorySanitizer disabled for target ${TARGET} because "
             "MemorySanitizer is supported for Linux systems only.")
         set(SANITIZE Off CACHE BOOL
-            "should sanitizers be enabled in debug mode if available" FORCE)
+            "should sanitizers be enabled if available" FORCE)
         set(${FLAG_CANDIDATES} "")
     elseif (NOT ${CMAKE_SIZEOF_VOID_P} EQUAL 8)
         message(WARNING "MemorySanitizer disabled for target ${TARGET} because "
             "MemorySanitizer is supported for 64bit systems only.")
         set(SANITIZE Off CACHE BOOL
-            "should sanitizers be enabled in debug mode if available" FORCE)
+            "should sanitizers be enabled if available" FORCE)
         set(${FLAG_CANDIDATES} "")
     else ()
         sanitizer_check_compiler_flags("${FLAG_CANDIDATES}" "MemorySanitizer"

cmake/Modules/FindTSan.cmake

@@ -34,12 +34,12 @@ if(${SANITIZE} STREQUAL "thread")
         message(WARNING "ThreadSanitizer disabled for target ${TARGET} because "
           "ThreadSanitizer is supported for Linux and macOS systems only.")
         set(SANITIZE Off CACHE BOOL
-            "should sanitizers be enabled in debug mode if available" FORCE)
+            "should sanitizers be enabled if available" FORCE)
     elseif (NOT ${CMAKE_SIZEOF_VOID_P} EQUAL 8)
         message(WARNING "ThreadSanitizer disabled for target ${TARGET} because "
             "ThreadSanitizer is supported for 64bit systems only.")
         set(SANITIZE Off CACHE BOOL
-            "should sanitizers be enabled in debug mode if available" FORCE)
+            "should sanitizers be enabled if available" FORCE)
     else ()
         sanitizer_check_compiler_flags("${FLAG_CANDIDATES}" "ThreadSanitizer"
             "TSan")

src/CMakeLists.txt

@@ -1118,12 +1118,12 @@ include(GenerateExportHeader)
 generate_export_header(libscip BASE_NAME scip EXPORT_FILE_NAME ${PROJECT_BINARY_DIR}/scip/scip_export.h)
 target_compile_definitions(scip PRIVATE SCIP_STATIC_DEFINE)
 
-if(CMAKE_BUILD_TYPE STREQUAL "Debug" AND SANITIZE)
+if(SANITIZE)
     find_package(Sanitizers)
     add_sanitizers(libscip)
     add_sanitizers(scip)
     get_target_property(CONF_SANITIZE_FLAGS libscip SANITIZE_FLAGS)
-endif()
+endif(SANITIZE)
 
 target_link_libraries(scip
    PUBLIC

tests/CMakeLists.txt

@@ -64,9 +64,9 @@ if( CRITERION_FOUND )
     #
     include_directories(${CRITERION_INCLUDE_DIRS} ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/../src)
 
-    if(CMAKE_BUILD_TYPE STREQUAL "Debug" AND SANITIZE)
+    if(SANITIZE)
         find_package(Sanitizers)
-    endif()
+    endif(SANITIZE)
 
     #
     # Prepare unit test executable for every source file
@@ -101,9 +101,9 @@ if( CRITERION_FOUND )
         #
         target_link_libraries(${testName} ${CRITERION_LIBRARIES} libscip m)
 
-        if(CMAKE_BUILD_TYPE STREQUAL "Debug" AND SANITIZE)
+        if(SANITIZE)
             add_sanitizers(${testName})
-        endif()
+        endif(SANITIZE)
 
         #
         # use the directory name (relative to src/) to build the executable