-
Notifications
You must be signed in to change notification settings - Fork 270
Add enableDebugSol following discussion on mailing list #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
In my opinion the debug solution mechanism could be enabled in |
Sounds good, Dominik, thank you! Mark raised a valid point, however, of having code working only for specific SCIP builds. I'm going to add an assert that SCIP is indeed in debug mode, just need to figure out what to query from SCIP. |
I guess you actually want to check whether |
I've never used |
A test for the added functions is difficult without a way to get the current state, and testing the debug solution mechanism itself is also involved since an assertion fail would need to be identified, so I would not insist on it. |
Co-authored-by: DominikKamp <[email protected]>
Alright, Dominik, thank you for the review, as always. I'll see what Benjamin ends up sending, and decide later if it can be turned into a test. |
@DominikKamp can you please approve? |
@Joao-Dionisio Have you checked locally that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the define works, this is fine.
See details here: https://listserv.zib.de/pipermail/scip/2025-June/005038.html
Want to add tests before merging. In general, it might be good to have some of the tests run on debug mode. Any opinion @DominikKamp?