Skip to content

Add enableDebugSol following discussion on mailing list #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Joao-Dionisio
Copy link
Member

@Joao-Dionisio Joao-Dionisio commented Jun 27, 2025

See details here: https://listserv.zib.de/pipermail/scip/2025-June/005038.html

Want to add tests before merging. In general, it might be good to have some of the tests run on debug mode. Any opinion @DominikKamp?

@DominikKamp
Copy link
Contributor

In my opinion the debug solution mechanism could be enabled in Model.__init__() like in SCIPrunShell() maybe controlled by an additional parameter. Interfacing SCIPenableDebugSol() is also okay. But then SCIPdisableDebugSol() should be added as well.

@Joao-Dionisio
Copy link
Member Author

Sounds good, Dominik, thank you! Mark raised a valid point, however, of having code working only for specific SCIP builds. I'm going to add an assert that SCIP is indeed in debug mode, just need to figure out what to query from SCIP.

@DominikKamp
Copy link
Contributor

I guess you actually want to check whether WITH_DEBUG_SOLUTION is defined.

@Joao-Dionisio
Copy link
Member Author

I've never used WITH_DEBUG_SOL, but I feel more comfortable not adding more stuff to the Model class that might confuse newcomers. I'll ask Benjamin for the test, and then I think we're good to go.

@DominikKamp
Copy link
Contributor

A test for the added functions is difficult without a way to get the current state, and testing the debug solution mechanism itself is also involved since an assertion fail would need to be identified, so I would not insist on it.

Joao-Dionisio and others added 2 commits July 5, 2025 00:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: DominikKamp <[email protected]>
@Joao-Dionisio Joao-Dionisio marked this pull request as ready for review July 4, 2025 23:54
@Joao-Dionisio
Copy link
Member Author

Alright, Dominik, thank you for the review, as always. I'll see what Benjamin ends up sending, and decide later if it can be turned into a test.

@Joao-Dionisio Joao-Dionisio enabled auto-merge (squash) July 5, 2025 09:59
@Joao-Dionisio Joao-Dionisio self-assigned this Jul 5, 2025
@Joao-Dionisio
Copy link
Member Author

@DominikKamp can you please approve?

@DominikKamp
Copy link
Contributor

@Joao-Dionisio Have you checked locally that WITH_DEBUG_SOLUTION is set to True when linking SCIP with DEBUGSOL=true (I am not sure where the initialization happens)?

@DominikKamp DominikKamp disabled auto-merge July 5, 2025 10:44
Copy link
Contributor

@DominikKamp DominikKamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the define works, this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants