Add basic jspreadsheet POC [SCI-11099] #7944
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignatov-bio
added
do-not-merge ⚠️
do-not-review ⚠️
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -12,6 +12,8 @@ import 'bootstrap'; | |||
| require('bootstrap-select/js/bootstrap-select'); | |||
| import '@vuepic/vue-datepicker/dist/main.css'; | |||
| import 'vue3-draggable-resizable/dist/Vue3DraggableResizable.css' | |||
| import "jsuites/dist/jsuites.css"; | |||
| import "jspreadsheet/dist/jspreadsheet.css"; | |||
There was a problem hiding this comment.
Import in body of module; reorder to top import/first
Strings must use singlequote quotes
| @@ -12,6 +12,8 @@ import 'bootstrap'; | |||
| require('bootstrap-select/js/bootstrap-select'); | |||
| import '@vuepic/vue-datepicker/dist/main.css'; | |||
| import 'vue3-draggable-resizable/dist/Vue3DraggableResizable.css' | |||
| import "jsuites/dist/jsuites.css"; | |||
There was a problem hiding this comment.
Import in body of module; reorder to top import/first
Strings must use singlequote quotes
| @import '~material-icons-font/sass/mixins'; // mandatory and after variables | ||
| $MaterialIcons_FontPath: "~material-icons-font/fonts"; // for CLI project we change font path to point into package fonts folder | ||
| @import '~material-icons-font/sass/main'; // mandatory main material font definition | ||
| @import '~material-icons-font/sass/Regular'; // mandatory @font-face definition |
| @import '~material-icons-font/sass/variables'; // mandatory and at first place | ||
| @import '~material-icons-font/sass/mixins'; // mandatory and after variables | ||
| $MaterialIcons_FontPath: "~material-icons-font/fonts"; // for CLI project we change font path to point into package fonts folder | ||
| @import '~material-icons-font/sass/main'; // mandatory main material font definition |
| /// Must be relplaced with our icons | ||
| @import '~material-icons-font/sass/variables'; // mandatory and at first place | ||
| @import '~material-icons-font/sass/mixins'; // mandatory and after variables | ||
| $MaterialIcons_FontPath: "~material-icons-font/fonts"; // for CLI project we change font path to point into package fonts folder |
There was a problem hiding this comment.
Name of variable MaterialIcons_FontPath should be written in all lowercase letters with hyphens instead of underscores
|
|
||
|
|
||
| /// Must be relplaced with our icons | ||
| @import '~material-icons-font/sass/variables'; // mandatory and at first place |
| @@ -278,6 +310,7 @@ export default { | |||
| }); | |||
| }, | |||
| loadTableData() { | |||
| return | |||
| @@ -265,7 +296,8 @@ export default { | |||
| }); | |||
| } | |||
|
|
|||
| this.$emit('update', this.element, false, callback); | |||
|
|
|||
There was a problem hiding this comment.
More than 1 blank line not allowed no-multiple-empty-lines
| @@ -152,7 +175,7 @@ export default { | |||
| if (!this.updatingTableData) this.loadTableData(); | |||
| }, | |||
| beforeUpdate() { | |||
| if (!this.updatingTableData) this.tableObject.destroy(); | |||
| //if (!this.updatingTableData) this.tableObject.destroy(); | |||
There was a problem hiding this comment.
Expected space or tab after '//' in comment spaced-comment
| @@ -63,11 +76,18 @@ import InlineEdit from '../inline_edit.vue'; | |||
| import TableNameModal from './modal/table_name.vue'; | |||
| import moveElementModal from './modal/move.vue'; | |||
| import MenuDropdown from '../menu_dropdown.vue'; | |||
| import { Spreadsheet, Worksheet } from "@jspreadsheet/vue"; | |||
aignatov-bio
force-pushed
the
ai-sci-11099-jspreadsheet-poc
branch
from
f2c0c8b to
7e30318
Compare
| editingName: false, | ||
| editingTable: false, | ||
| editingCell: false, | ||
| tableObject: null, | ||
| nameModalOpen: false, | ||
| reloadHeader: 0, | ||
| updatingTableData: false | ||
| updatingTableData: false, |
There was a problem hiding this comment.
Unexpected trailing comma comma-dangle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: SCI-11099
What was done
This pull request introduces several changes to integrate the
jspreadsheetlibrary for spreadsheet functionalities and thematerial-icons-fontfor icon management in the project. The most important changes include adding new dependencies, updating stylesheets, and modifying Vue components to incorporate the new spreadsheet functionality.Integration of
jspreadsheet:app/javascript/packs/application.js: Added imports forjspreadsheetandjsuitesstylesheets.app/javascript/vue/shared/content/table.vue: IntegratedSpreadsheetandWorksheetcomponents from@jspreadsheet/vue, added data handling methods, and updated lifecycle hooks. [1] [2] [3] [4] [5] [6] [7] [8]app/views/layouts/application.html.erb: Added a meta tag to include thejspreadsheetlicense key from environment variables.package.json: Added@jspreadsheet/vueas a new dependency.Integration of
material-icons-font:app/javascript/packs/application.scss: Added imports and configurations formaterial-icons-fontto manage icon fonts.package.json: Addedmaterial-icons-fontas a new dependency.