-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TNS API fix and a few others #282
Conversation
@djones1040 I merged main into your branch and then added some commits. In particular, please review my changes to the TNS ingest function here. The logic of this function appears to have become convoluted over time so I refactored it to make it easier to understand and hopefully be less prone to error. Workflows are running in my local dev environment as of commit 309815d, and the output of a test transient I uploaded yields different calculated values for equivalent workflow task statuses. |
There is another concern I have about the consistency of TNS ingest and processing logic. Search the code for the four instances of |
@djones1040 and I examined the code together and determined that there is no inconsistency. |
@djones1040 determined that there is a bug in the aperture photometry code introduced by commit b065674 that he will fix prior to merging this branch. |
Fixes # .
Description of the Change
Checklist
Please check all that apply to your proposed changes
Additional context