TST improve metadata routing tests #29226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam2392
reviewed
Jun 10, 2024
Co-authored-by: Adam Li <[email protected]>
Co-authored-by: Adam Li <[email protected]>
Co-authored-by: Adam Li <[email protected]>
glemaitre
reviewed
Jun 10, 2024
Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
approved these changes
Jun 12, 2024
|
@OmarManzoor you think you could have a look and hopefully merge maybe? |
|
@adrinjalali Sure I'll have a look soon. |
OmarManzoor
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the tests for metadata routing in the way things are recorded and checked in test estimators.
This came up when working on Pipeline's
transform_input(#28901) and made finding a few issues much easier.@glemaitre @OmarManzoor this should be easy-ish to merge, and would make the pipeline PR much smaller and easier to review, and should help @adam2392 with another SLEP6 PR.