Repository navigation
TST improve metadata routing tests - #29226
Merged
Merged
Conversation
adam2392
reviewed
Jun 10, 2024
adam2392
left a comment
adam2392
left a comment
Member
There was a problem hiding this comment.
Awesome! Thanks for the PR to make the metadata testing easier.
Co-authored-by: Adam Li <adam2392@gmail.com>
Co-authored-by: Adam Li <adam2392@gmail.com>
Co-authored-by: Adam Li <adam2392@gmail.com>
glemaitre
self-requested a review
June 10, 2024 14:39
glemaitre
reviewed
Jun 10, 2024
glemaitre
left a comment
glemaitre
left a comment
Member
There was a problem hiding this comment.
LGTM. I only have one portion that I don't recall what we are doing there.
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
glemaitre
approved these changes
Jun 12, 2024
Member
Author
|
@OmarManzoor you think you could have a look and hopefully merge maybe? |
Contributor
|
@adrinjalali Sure I'll have a look soon. |
OmarManzoor
approved these changes
Jun 14, 2024
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @adrinjalali
I just have one question.
OmarManzoor
enabled auto-merge (squash)
June 14, 2024 10:03
StefanieSenger
added
the
Metadata Routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the tests for metadata routing in the way things are recorded and checked in test estimators.
This came up when working on Pipeline's
transform_input(#28901) and made finding a few issues much easier.@glemaitre @OmarManzoor this should be easy-ish to merge, and would make the pipeline PR much smaller and easier to review, and should help @adam2392 with another SLEP6 PR.