add developer API post #198
Conversation
Yes that was the goal IIRC. |
Co-authored-by: Jérémie du Boisberranger <[email protected]>
There was a problem hiding this comment.
LGTM if Guillaume's message on discord https://discord.com/channels/731163543038197871/1046822941586898974/1316511187005079553 doesn't receive negative feedback.
| cycle warning. | ||
|
|
||
| In the past few releases, we've slowly introduced more functionalities under this | ||
| umbrella. `__sklearn_clone__` and `__sklearn_is_fitted__` are two examples. |
There was a problem hiding this comment.
Is there an easy way to tell what is part of this developer API? If yes we could mention it here. If no, we could create it at some point later (not needed for this blog post)
| In the past few releases, we've slowly introduced more functionalities under this | ||
| umbrella. `__sklearn_clone__` and `__sklearn_is_fitted__` are two examples. | ||
|
|
||
| In the latest release, at the time of writing this post, we focused on the testing |
There was a problem hiding this comment.
(not sure why i cant suggest a change directly)
Should we just say "In the 1.6 release, we focussed on ..."?
| ``` | ||
|
|
||
| The new tags mostly follow the same structure as the old tags, but there are certain | ||
| changes to them. The main change is that the old `_xfail_checks` is no more present |
There was a problem hiding this comment.
"is no more present" -> "is no longer present"
| ``` | ||
|
|
||
| While working on the testing infrastructure, we have also been working on improving our | ||
| tests and that means in this release we had a particularly higher number of changes in |
There was a problem hiding this comment.
| tests and that means in this release we had a particularly higher number of changes in | |
| tests and that means in this release we had a particularly high number of changes in |
|
|
||
| While working on the testing infrastructure, we have also been working on improving our | ||
| tests and that means in this release we had a particularly higher number of changes in | ||
| their names and what they do. The changes should have made it easier for developers to |
There was a problem hiding this comment.
"The changes should have" -> "The changes will make it easier for"
"should have" somehow sounds like it was a failed attempt. "Increasing prices should have reduced demand for ice cream, however queues are longer than ever"
| `check_estimator` and `parametrize_with_checks` to include only strictly API related | ||
| tests. | ||
|
|
||
| The above changes means developers need to update their estimators and depending on |
There was a problem hiding this comment.
| The above changes means developers need to update their estimators and depending on | |
| The above changes mean developers need to update their estimators and depending on |
|
Left a few style comments, otherwise this looks good to me. Useful information! |
We can also add a link to this from our release highlights.