Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX worklow issue with macos-python3.11 #429

Merged

Conversation

BaptisteCalot
Copy link
Collaborator

Description

With this PR : ENH: move get_true_label_position to utils in classification #427, something is wrong with the unitary test in the CI for mac OS.

I want to check whether the issue stems from the modifications that have been made in this PR or if this problem has been there from the beginning

@BaptisteCalot BaptisteCalot linked an issue Apr 12, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (614293e) to head (f8a0305).
Report is 284 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #429    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        39            
  Lines         4616      4895   +279     
  Branches       487       774   +287     
==========================================
+ Hits          4616      4895   +279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LacombeLouis LacombeLouis self-assigned this Apr 15, 2024
@LacombeLouis
Copy link
Collaborator

It seems to work with the following env shown below. Hence, this issue seems to be with the python version (3.11 now and 3.10 in this version) and compatibility with joblib library as shown in these issues: link1, link2.

# This file may be used to create an environment using:
# $ conda create --name <env> --file <this file>
# platform: osx-64
@EXPLICIT
https://repo.anaconda.com/pkgs/main/osx-64/bzip2-1.0.8-h6c40b1e_5.conda
https://repo.anaconda.com/pkgs/main/osx-64/ca-certificates-2024.3.11-hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/libcxx-14.0.6-h9765a3e_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/llvm-openmp-14.0.6-h0dcd299_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/ncurses-6.4-hcec6c5f_0.conda
https://repo.anaconda.com/pkgs/main/noarch/tzdata-2024a-h04d1e81_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/xz-5.4.6-h6c40b1e_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/zlib-1.2.13-h4dc903c_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/libffi-3.3-hb1e8313_2.conda
https://repo.anaconda.com/pkgs/main/osx-64/libgfortran5-11.3.0-h9dfd629_28.conda
https://repo.anaconda.com/pkgs/main/osx-64/openssl-1.1.1w-hca72f7f_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/readline-8.2-hca72f7f_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/tk-8.6.12-h5d9f67b_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/libgfortran-5.0.0-11_3_0_hecd8cb5_28.conda
https://repo.anaconda.com/pkgs/main/osx-64/sqlite-3.41.2-h6c40b1e_0.conda
https://conda.anaconda.org/conda-forge/osx-64/libopenblas-0.3.21-openmp_h429af6e_3.tar.bz2
https://repo.anaconda.com/pkgs/main/osx-64/python-3.10.0-hdfd78df_5.tar.bz2
https://repo.anaconda.com/pkgs/main/osx-64/brotli-python-1.0.9-py310he9d5cce_7.conda
https://repo.anaconda.com/pkgs/main/osx-64/certifi-2024.2.2-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/noarch/charset-normalizer-2.0.4-pyhd3eb1b0_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/exceptiongroup-1.2.0-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/idna-3.4-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/noarch/iniconfig-1.1.1-pyhd3eb1b0_0.tar.bz2
https://repo.anaconda.com/pkgs/main/osx-64/joblib-1.2.0-py310hecd8cb5_0.conda
https://conda.anaconda.org/conda-forge/osx-64/libblas-3.9.0-16_osx64_openblas.tar.bz2
https://repo.anaconda.com/pkgs/main/noarch/mccabe-0.7.0-pyhd3eb1b0_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/mypy_extensions-1.0.0-py310hecd8cb5_0.conda
https://conda.anaconda.org/conda-forge/osx-64/openblas-0.3.21-openmp_hbefa662_3.tar.bz2
https://repo.anaconda.com/pkgs/main/osx-64/packaging-23.2-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/pluggy-1.0.0-py310hecd8cb5_1.conda
https://repo.anaconda.com/pkgs/main/osx-64/psutil-5.9.0-py310hca72f7f_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/pycodestyle-2.11.1-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/pyflakes-3.2.0-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/pysocks-1.7.1-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/noarch/python-tzdata-2023.3-pyhd3eb1b0_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/pytz-2023.3.post1-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/setuptools-68.2.2-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/noarch/six-1.16.0-pyhd3eb1b0_1.conda
https://repo.anaconda.com/pkgs/main/noarch/threadpoolctl-2.2.0-pyh0d69192_0.conda
https://repo.anaconda.com/pkgs/main/noarch/toml-0.10.2-pyhd3eb1b0_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/tomli-2.0.1-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/typed-ast-1.5.5-py310h6c40b1e_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/typing_extensions-4.9.0-py310hecd8cb5_1.conda
https://repo.anaconda.com/pkgs/main/osx-64/wheel-0.41.2-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/coverage-7.2.2-py310h6c40b1e_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/flake8-7.0.0-py310hecd8cb5_0.conda
https://conda.anaconda.org/conda-forge/osx-64/libcblas-3.9.0-16_osx64_openblas.tar.bz2
https://conda.anaconda.org/conda-forge/osx-64/liblapack-3.9.0-16_osx64_openblas.tar.bz2
https://repo.anaconda.com/pkgs/main/osx-64/pip-23.3.1-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/pytest-7.4.0-py310hecd8cb5_0.conda
https://repo.anaconda.com/pkgs/main/noarch/python-dateutil-2.8.2-pyhd3eb1b0_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/typing-extensions-4.9.0-py310hecd8cb5_1.conda
https://repo.anaconda.com/pkgs/main/osx-64/urllib3-2.1.0-py310hecd8cb5_1.conda
https://conda.anaconda.org/conda-forge/osx-64/liblapacke-3.9.0-16_osx64_openblas.tar.bz2
https://repo.anaconda.com/pkgs/main/osx-64/mypy-1.8.0-py310h6c40b1e_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/pytest-cov-4.1.0-py310hecd8cb5_1.conda
https://repo.anaconda.com/pkgs/main/osx-64/requests-2.31.0-py310hecd8cb5_1.conda
https://conda.anaconda.org/conda-forge/osx-64/blas-devel-3.9.0-16_osx64_openblas.tar.bz2
https://repo.anaconda.com/pkgs/main/noarch/codecov-2.1.11-pyhd3eb1b0_0.conda
https://conda.anaconda.org/conda-forge/osx-64/blas-2.116-openblas.tar.bz2
https://repo.anaconda.com/pkgs/main/osx-64/numpy-base-1.25.2-py310hd8f4981_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/numpy-1.25.2-py310hf6dca73_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/bottleneck-1.3.7-py310h7b7cdfe_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/numexpr-2.8.7-py310hf6dca73_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/scipy-1.12.0-py310ha516a68_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/pandas-2.2.1-py310hcec6c5f_0.conda
https://repo.anaconda.com/pkgs/main/osx-64/scikit-learn-1.3.0-py310h3ea8b11_1.conda

@LacombeLouis
Copy link
Collaborator

@vincentblot28 what do you think about this fix? We will need to check out for a correction in python 3.11, but I think this solves the issue temporarily.

@LacombeLouis LacombeLouis changed the title TRY Code changes without any impact to make a PR FIX worklow issue with macos-python3.11 Apr 30, 2024
@LacombeLouis LacombeLouis requested a review from vincentblot28 May 3, 2024 13:26
@LacombeLouis LacombeLouis merged commit 3813eae into master May 3, 2024
8 checks passed
@Valentin-Laurent Valentin-Laurent deleted the 428-something-is-wrong-with-unitary-test-and-mac-os branch November 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something is wrong with unitary test and mac os
5 participants