-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix source code and javadoc lookup functions #44
Conversation
The common case these days is to open the source code in the browser -- typically on GitHub, but whatever SCM URL the POM lists.
The "http://fiji.sc/Foo.java" shortcut has not worked for many years. And will not be made to work again, due to security considerations. Instead, we look in the POM and/or JAR manifest for the given class.
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will test right away.
Sorry, merged too early: can't get it to work. This is related to selecting a chunk of text containing the simple name of a class, and then running "Tools / Open help for class..." and having a web browser open and showing the class, right? I've compiled locally and I may have messed up mvn again, because I can't get this functionality to work. Got error, when running for
|
@acardona Does it work if you select the fully qualified name of the class? Did it used to work from only the simple name of the class? If so, I can try to figure out how to restore that behavior... |
When running for net.imglib2.type.numeric.integer.UnsignedByteType I get:
And yes: this functionality only ever worked for simple class names. Used to open a choose dialog, IIRC, when there were multiple possible class names. Perhaps a temp replacement would be to open a browser that googles for the class name? Although what I think could work is to get the root class loader and to systematically search for the class name, so as to get the fully qualified class name, and from there search in scijava javadoc. If not present there, then open a google search for it. |
@acardona wrote:
This reminds me of the open issue to restore the Add import functionality: In both cases, we need to detect the correct package given just the bare class name. |
We don't publish SNAPSHOT versions to Maven Central, so javadoc.io cannot serve them. It should work if you use a release version of imglib2. |
This fixes the following commands: