LogService: Make getLevel() more robust against ClassNotFoundException #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class.forName() will fail if the threads class loader is not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue: #410
Previously: If fine grained log levels are set LogService would call
CallingClassUtils.getCallingClass()to find the appropriate log level for this class. This process would fail if the calling class could not be loaded with the default class loader. A IllegalStateException would be thrown instead.This PR fixes this behavior. The class name is used rather the the class object. This avoids using
Class.forName(...)if possible. ButClass.forName(...)is still used to check for the presence of theIgnoreAsCallingClassannotation.