Convert SciJava Types Tests to JUnit 5 #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
gselzer
force-pushed
the
scijava/scijava-types/junit-5
branch
from
99b3994 to
6e6973e
Compare
gselzer
force-pushed
the
scijava/scijava-types/junit-5
branch
from
6e6973e to
3d0e39e
Compare
gselzer
force-pushed
the
scijava/scijava-types/junit-5
branch
from
3d0e39e to
cb715c3
Compare
ctrueden
force-pushed
the
scijava/scijava-types/junit-5
branch
from
cb715c3 to
902bb70
Compare
ctrueden
approved these changes
Jun 30, 2022
Member
ctrueden
left a comment
ctrueden
left a comment
There was a problem hiding this comment.
Great! One component down, eight more to go. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does what it says above.
The POM only listed
org.junitandorg.junit.jupiter.apias dependencies, which is very strange. Furthermore, it would only run JUnit 4 tests, which represented very few of this project's tests. This PR replacesorg.junitwithorg.junit.jupiter.engine, and converts all tests still running JUnit 4.TODO: