-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Therapi-based Discovery #44
Merged
ctrueden
merged 11 commits into
main
from
scijava/scijava-ops-engine/therapi-discoverer
Apr 13, 2022
Merged
Therapi-based Discovery #44
ctrueden
merged 11 commits into
main
from
scijava/scijava-ops-engine/therapi-discoverer
Apr 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
force-pushed
the
scijava/scijava-ops-engine/therapi-discoverer
branch
2 times, most recently
from
October 18, 2021 19:36
6dd64d8
to
347e3be
Compare
Note: This is the first step towards completing scijava/scijava#56 |
gselzer
force-pushed
the
scijava/scijava-ops-engine/therapi-discoverer
branch
from
October 18, 2021 21:04
347e3be
to
b6ece7b
Compare
This was referenced Nov 15, 2021
gselzer
force-pushed
the
scijava/scijava-ops-engine/therapi-discoverer
branch
from
November 16, 2021 19:19
b6ece7b
to
fb7d30c
Compare
This commit provides major changes to the Discoverer interface. 1. We rename implementingClasses to implsOfType 2. We add the elementsTaggedWith(String key) method 3. We make both elements default, so that Discoverers can decide to implement only one of the two methods.
This commit also refactors the OpInfo implementations to prevent them from definning the Hints and priority. We might want to define these using something other than an annotation...
ctrueden
force-pushed
the
scijava/scijava-ops-engine/therapi-discoverer
branch
from
April 13, 2022 17:25
fb7d30c
to
e303bc5
Compare
ctrueden
force-pushed
the
scijava/scijava-ops-engine/therapi-discoverer
branch
from
April 13, 2022 17:32
e303bc5
to
d0d8479
Compare
ctrueden
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Therapi-based Op Discovery mechanism via the new
scijava/scijava-discovery-therapi
module. This module enables "element-tagged" discovery through the use of the@implNote
javadoc tag.How do I declare an Op using Therapi?
@implNote
to anyClass
,Method
orField
. The@implNote
annotation should be followed with (1) the tag type (i.e. the keyword under which thisAnnotatedElement
will become discoverable) and (2) any (comma-delineated) key-value pairs that should be scraped with the tag.Note that the tags are parsed using Parsington, as the
org.scijava.parse
package from SciJava Common was moved into the incubator and modularized into SciJava Parse2.An Op written as a
Field
discoverable using therapi might look like:Ops written as
Method
s require atype
option:This PR also refactors the
Discoverer
andDiscovery
API from SciJava Discovery to make the discovery returns much more powerful.Furthermore, this PR also introduces SciJava Parse2 to the incubator, partitioning out
org/scijava/parse
from SciJava Common.Closes scijava/scijava#77