Remove OpEnvironment.infoTree() #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was no longer necessary with the Ops.infoTree() utility method
hinerm
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was no longer necessary with the
Ops.infoTree()utility methodThe only reason I can think of to keep this is because it is extensible. Notably,
Ops.infoTree()only works if the passed argument is aRichOp, which is not a requirement ofOpEnvironment.op(), or theOpBuildercalls. Therefore, removing this method could prevent us from obtainingInfoTrees from futureOpEnvironmentimplementations. This could be a YAGNI at the end of the day, looking for others' opinions.