Improve Conversion with Anys & Other Types Goodness #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
force-pushed
the
scijava-ops-engine/conversion-anys
branch
8 times, most recently
from
626cd6e to
0395de9
Compare
gselzer
force-pushed
the
scijava-ops-engine/conversion-anys
branch
from
0395de9 to
e04ea9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally designed to close scijava/scijava#202, however I found myself frustrated that the identity Op was not being properly respected. To that end, I made some changes to the
GenericAssignabilityutility class to be a bit stricter, and more correct.@elevans once this is cleaner I'd love it if you could test this.
TODO:
Closes scijava/scijava#202