Rewrite to json from bson #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to API, removal of most class arguments. Removal of bson/mongo dep, add gson dep. Update to tests
gselzer
requested changes
Apr 6, 2022
There was a problem hiding this comment.
Thanks for this @tomburke-rse! It looks a lot better!
I had some comments, mostly about making the code DRYer.
src/main/java/net/imglib2/labeling/DefaultLabelingIOService.java
Outdated
Show resolved
Hide resolved
src/main/java/net/imglib2/labeling/DefaultLabelingIOService.java
Outdated
Show resolved
Hide resolved
src/main/java/net/imglib2/labeling/DefaultLabelingIOService.java
Outdated
Show resolved
Hide resolved
src/main/java/net/imglib2/labeling/DefaultLabelingIOService.java
Outdated
Show resolved
Hide resolved
src/test/java/net/imglib2/labeling/tutorials/E01_LoadLabeling.java
Outdated
Show resolved
Hide resolved
gselzer
approved these changes
Apr 18, 2022
src/main/java/net/imglib2/labeling/DefaultLabelingIOService.java
Outdated
Show resolved
Hide resolved
|
@tomburke-rse at this point it builds with passing tests. Let's merge (and release) it! |
* Reactivate tests * Method refactoring
Add TypeToken wrapper to circumvent gson dependency in implementing projects
Can all be done on one line.
This prevents vacuous type parameters!
ctrueden
force-pushed
the
switch-bson-with-json
branch
from
ebf4c5a to
b658367
Compare
|
I tested all commits and rewrote the message of the WIP commit to reflect that it is not a WIP (it successfully compiles with passing tests). Should be good to merge now, so I'm doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the API has been moved to JSON.
The function-based mapping still needs to be solved.
Minimal changelog:
If this all looks fine with you @gselzer, feel free to merge, build and release.