Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request access for sunpy #50

Closed
nabobalis opened this issue Dec 30, 2023 · 17 comments
Closed

Request access for sunpy #50

nabobalis opened this issue Dec 30, 2023 · 17 comments
Labels
new project question Further information is requested

Comments

@nabobalis
Copy link

nabobalis commented Dec 30, 2023

Hello!

We (over at the sunpy project) want to provide a nightly wheel for our core package, sunpy.
I think we might come under the definition of core, at least within our little ecosystem in solar physics. Packages like astropy's reproject I think have CI that checks against dev sunpy, so a wheel there would be helpful.

Would it be possible to gain access?

Happy Holidays.

@matthewfeickert
Copy link
Member

👋 Thanks for the Issue. This is the right place to raise such a request, but we're unfortunately still deciding how to address them. Please join the discussion over on Issue #45.

(Apologies for the short response. I'm traveling at the moment and have a broken computer so I'm stuck on GitHub's mobile app till I fix that.)

@bsipocz
Copy link
Member

bsipocz commented Jan 1, 2024

I think it would make a lot of sense to do an openastronomy registry and serve wheels for sunpy, astropy, pyerfa, etc from there, as these are way less core packages in the sense of the whole ecosystem than e.g. awkward et al. But they are clearly and definitely domain ones.

@bsipocz
Copy link
Member

bsipocz commented Jan 1, 2024

That said, we should definitely go ahead and merge #47 as soon as possible, so the infrastructure can be shared and reused even for a different registry

@nabobalis
Copy link
Author

Where would we host an openastronomy registry?

Happy to get involved in helping that if possible.

@bsipocz
Copy link
Member

bsipocz commented Jan 4, 2024

on anaconda, just as it's done for liberfa and astropy atm. Pey Lian just raised the idea that there should be wheels for photutils, and I suppose for regions, too, so an openastronomy registry for astropy/sunpy and their close (well-maintained) ecosystem makes even more sense to me now that a couple of days ago 😄

@bsipocz bsipocz added the question Further information is requested label Jan 4, 2024
@nabobalis
Copy link
Author

Makes sense to me. I see there is an https://anaconda.org/openastronomy I just need an access token to start uploading? I need to look at the workflow and see how it works.

@matthewfeickert
Copy link
Member

matthewfeickert commented Feb 23, 2024

@nabobalis Good news, we have the approval (#30 (comment)) to add sunpy to the nightly wheels Anaconda Cloud org https://anaconda.org/scientific-python-nightly-wheels/ !

To get started on this can you please do the following:

Steps to gain upload access to https://anaconda.org/scientific-python-nightly-wheels/

image

If you'd also like to use the scientific/upload-nightly-action GitHub Action that this repository provides please check out this repo's README. If you need to collect wheels from different CI jobs, consider creating a new GitHub Actions workflow with logic similar to matplotlib's or Awkward's.

If you have any questions please just ask here!

@nabobalis
Copy link
Author

@nabobalis Good news, we have the approval (#30 (comment)) to add sunpy to the nightly wheels Anaconda Cloud org anaconda.org/scientific-python-nightly-wheels !

Thank you!

Steps to gain upload access to anaconda.org/scientific-python-nightly-wheels

  • Create an account on Anaconda Cloud
  • Reply here with the link to your account

Would a sunpy (non-personal) account be ok? https://anaconda.org/sunpy/

Hopefully a dropbox link is ok: https://www.dropbox.com/scl/fi/mvauudyw1fihh1pegvy4n/sunpy-6.0.dev213-gbf6eb5884-cp310-abi3-linux_x86_64.whl?rlkey=vjlkynjuw1l5gmqlvq0310vix&dl=0

Our cron CI is having some issues at the moment.

@matthewfeickert
Copy link
Member

Would a sunpy (non-personal) account be ok? https://anaconda.org/sunpy/

@nabobalis What matters is that the API token is associated with the account. Is the API token you currently use associated with the sunpy org account?

I used the wheel you linked me to create the project https://anaconda.org/scientific-python-nightly-wheels/sunpy, so once we have the info on the account+API token pair to use then you should be good to start uploading.

@nabobalis
Copy link
Author

nabobalis commented Feb 27, 2024

Would a sunpy (non-personal) account be ok? anaconda.org/sunpy

@nabobalis What matters is that the API token is associated with the account. Is the API token you currently use associated with the sunpy org account?

Yes it is.

@matthewfeickert
Copy link
Member

@nabobalis Okay great. As long as you can see https://anaconda.org/scientific-python-nightly-wheels/groups/sunpy when logged in on the sunpy account then you should be good to go. 👍

@nabobalis
Copy link
Author

@nabobalis Okay great. As long as you can see anaconda.org/scientific-python-nightly-wheels/groups/sunpy when logged in on the sunpy account then you should be good to go. 👍

If I access that page, "I get You don't have permission to view this page." when I am logged into the sunpy account.

@matthewfeickert
Copy link
Member

If I access that page, "I get You don't have permission to view this page." when I am logged into the sunpy account.

Hm. Let me look into that but, the sunpy account has all the permissions for the sunpy group as other accounts do, so even if you can't see the group for some reason you should be able to upload to it.

Our cron CI is having some issues at the moment.

Once your build job is working again can you try to do an upload and then report back here?

@nabobalis
Copy link
Author

Will do. Thank you again.

@nabobalis
Copy link
Author

So we changed our CI, I hope correctly to upload:

sunpy/sunpy#7456

When our cronjob is back, we will hopefully find out if I added the correct token!

@nabobalis
Copy link
Author

We restored our cron and it worked: https://anaconda.org/scientific-python-nightly-wheels/sunpy/files

Thank you again for giving us access. I have updated the job (https://github.com/sunpy/sunpy/pull/7457/files) to (hopefully) keep the lastest wheel only. Hopefully we will not fill up your storage space.

@stefanv
Copy link
Member

stefanv commented Feb 27, 2024

Great! And no worries about storage; as long as we delete old wheels we'll be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new project question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants