Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Nightly dev wheel #1689

Closed
pllim opened this issue Jan 2, 2024 · 12 comments
Closed

FEAT: Nightly dev wheel #1689

pllim opened this issue Jan 2, 2024 · 12 comments

Comments

@pllim
Copy link
Member

pllim commented Jan 2, 2024

Since this package has C-extension, might be nice to have a nightly dev wheel uploaded like astropy, so downstream packages (e.g., acstools, jdaviz) do not have to build photutils from source for their devdeps jobs.

Maybe a simpler version of https://github.com/astropy/astropy/blob/main/.github/workflows/publish.yml

Will need @astrofrog's help to set up the upload destination. 🙏

@bsipocz
Copy link
Member

bsipocz commented Jan 4, 2024

I would strongly advocate for an openastronomy destination, that could host astropy, sunpy, pyerfa, photutils, regions, etc.

x-ref: cc @nabobalis and scientific-python/upload-nightly-action#50

(and would advocate reusing the SP upload action (once the pending PR, that would support an alternative upload location, is merged), as we do keep maintaining that for the core SP library wheels)

@pllim
Copy link
Member Author

pllim commented Jan 4, 2024

astropy (and pyerfa) already has an established and advertised location, so I probably won't move that. But other packages downstream sharing a space will be nice, if quota isn't an issue.

@bsipocz
Copy link
Member

bsipocz commented Jan 4, 2024

astropy (and pyerfa) already has an established and advertised location

that can also still nicely changed. As the pyerfa stuff is still not at all trivial or intuitive (and got used more widely only in the past month or so)

@pllim
Copy link
Member Author

pllim commented Jan 4, 2024

Re: astropy and/or pyerfa -- If it can have redirect, would be nice. Otherwise, will have to carefully plan the transition. Also pyerfa is technically not part of Astropy (it is upstream, so need to ask pyerfa devs).

@bsipocz
Copy link
Member

bsipocz commented Jan 4, 2024

pyerfa is technically not part of Astropy

Thus the "openastronomy" umbrella. As in practice as an astropy downstream user we only need the pyerfa wheel as astropy is otherwise incompatible, we have absolutely no direct or indirect usage of it.

@pllim
Copy link
Member Author

pllim commented Jan 4, 2024

Let me ping pyerfa (https://github.com/liberfa/pyerfa) devs: @avalentino @mhvk @astrofrog

@mhvk
Copy link

mhvk commented Jan 4, 2024

Definitely a good idea to have all the packages in a single location! (Though easy to say as I'm not sure how to actually do it...)

@larrybradley
Copy link
Member

@pllim Is there any interest in creating a shared location for astropy affiliated packages? Or should I close this?

@pllim
Copy link
Member Author

pllim commented Jul 11, 2024

creating a shared location for astropy affiliated packages?

@astrofrog owns the space where astropy core nightly wheel goes. He also set up pyerfa nightly wheel (separately). So he would be the best person to answer this.

@larrybradley
Copy link
Member

@astrofrog Do you have any plans to set this up? I know of a few packages that would benefit from having nightly photutils wheels.

@astrofrog
Copy link
Member

I'm happy to give it a go this week.

@larrybradley
Copy link
Member

Added in #1834. Currently the schedule is for a weekly dev build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants