-
Notifications
You must be signed in to change notification settings - Fork 3
Minor Updates #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Updates #17
Conversation
|
Testing downstream via https://github.com/LM-SAL/aiapy/actions/workflows/update-spec0.yaml Finally got it to open: LM-SAL/aiapy#377 |
|
TODO: Replace the download location to use this repo in the future. |
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is water under the bridge, but I think these should be fixed up in follow-up PR(s) and then tagging new releases.
| fi | ||
| - name: Fetch Schedule from release | ||
| uses: robinraju/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely for the third party actions please use the hashes, but maybe to be consistent do it for everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update
| - name: Fetch Schedule from release | ||
| uses: robinraju/[email protected] | ||
| with: | ||
| repository: "savente93/SPEC0-schedule" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not rely on a third party location for any SPEC0 related content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree but I need to get the release working on this repo first. Or even if we want to do it in this repo or a separate repo.
Updated spec0 file from the specs repo
Added the action to do a release of the schedule in a machine readable format from https://github.com/savente93/spec0-schedule
Added some tests with only setuptools pyproject toml files.