-
Notifications
You must be signed in to change notification settings - Fork 10
Update README && fix devstats.scientific-python.org build #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README && fix devstats.scientific-python.org build #73
Conversation
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct info, and the build failure is unrelated, so I would say the PR can go ahead as is and we leave it to the other PR to cleanup the submodule inconsistency.
|
Let me add another commit here so that we at least exercise the reporting functionality from a published data bundle. |
7219a37 to
8460618
Compare
|
Will now fix devstats.sp.org, and then hopefully everything will work. |
|
OK: scientific-python/devstats.scientific-python.org#46 That should go in first, then we can rerun the tests here. |
|
Once 46 and 73 are in, we can merge scientific-python/devstats-data#1, so that the website is rebuilt each time that the data bundle is updated. |
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it all looks good to me.
I checked on a couple of rendered HTML pages, and will add the redirect action separately to have the link easily available in the PRs.
|
Something is weird here, there shouldn't be 4 labeling statuses |
The website rebuild should now be done after the weekly data bundle artifact has been created, and should happen on the devstats.scientific-python.org repo.