Skip to content

Conversation

@stefanv
Copy link
Member

@stefanv stefanv commented Jan 10, 2025

The website rebuild should now be done after the weekly data bundle artifact has been created, and should happen on the devstats.scientific-python.org repo.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct info, and the build failure is unrelated, so I would say the PR can go ahead as is and we leave it to the other PR to cleanup the submodule inconsistency.

@stefanv
Copy link
Member Author

stefanv commented Jan 10, 2025

Let me add another commit here so that we at least exercise the reporting functionality from a published data bundle.

@stefanv stefanv marked this pull request as draft January 10, 2025 23:07
@stefanv stefanv force-pushed the remove-website-build-check branch from 7219a37 to 8460618 Compare January 10, 2025 23:15
@stefanv stefanv changed the title Update README; remove website build check Update README Jan 10, 2025
@stefanv stefanv marked this pull request as ready for review January 10, 2025 23:15
@stefanv stefanv changed the title Update README Update README && fix devstats.scientific-python.org build Jan 10, 2025
@stefanv
Copy link
Member Author

stefanv commented Jan 10, 2025

Will now fix devstats.sp.org, and then hopefully everything will work.

@stefanv stefanv added type: Documentation Improvements or additions to documentation type: Maintenance and removed type: Documentation Improvements or additions to documentation labels Jan 10, 2025
@stefanv
Copy link
Member Author

stefanv commented Jan 10, 2025

OK: scientific-python/devstats.scientific-python.org#46

That should go in first, then we can rerun the tests here.

@stefanv
Copy link
Member Author

stefanv commented Jan 10, 2025

Once 46 and 73 are in, we can merge scientific-python/devstats-data#1, so that the website is rebuilt each time that the data bundle is updated.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it all looks good to me.

I checked on a couple of rendered HTML pages, and will add the redirect action separately to have the link easily available in the PRs.

@bsipocz bsipocz merged commit 09d2fd5 into scientific-python:main Jan 11, 2025
4 of 6 checks passed
@jarrodmillman jarrodmillman added this to the 0.2 milestone Jan 11, 2025
@bsipocz
Copy link
Member

bsipocz commented Jan 11, 2025

Something is weird here, there shouldn't be 4 labeling statuses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants