Skip to content

Conversation

@lwasser
Copy link
Contributor

@lwasser lwasser commented May 25, 2023

closes #14
Hi y'all! i've updated the config yaml to support the pre-commit ci bot. Someone with maintainer priveledges to the organization will need to approve the bot for use in this org.

to do that please

  1. go here to the pre-commit.ci home page
  2. sign in to github
  3. Add the bot to the scientific-python organization
  4. give the bot permissions to access / run on this repo.
    The bot will initially be confused if there is no config for it in the main branch. So we will have to merge this PR for it to be less confused :)

I am happy to sit with someone to set this up while here at the summit!! it's super fast and once it's setup you can update the config.yaml file as needed to adjust tools and such that you want the bot to run.

NOTE: the bot WILL look across the entire repo when it runs on a PR. but once the repo has been styled and linted, it will only modify the files submitted in a PR because the other files are already cleaned up. This bot is a great way to support drive-by contributors who don't want to mess with setting up pre-commit hooks locally (they can confuse people!)

@lwasser
Copy link
Contributor Author

lwasser commented May 25, 2023

one other note - IF we implement this we can likely remove that lint.yml file and just use the precommit.ci bot to avoid redundancy but also add the feature of auto fixing code.

@jarrodmillman jarrodmillman merged commit 2b756d5 into scientific-python:main Jul 3, 2023
@jarrodmillman jarrodmillman added this to the 0.1 milestone Jul 3, 2023
@jarrodmillman jarrodmillman changed the title Add: precommit CI bot config to repo Add precommit CI bot config to repo Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup precommit.ci bot for devstats

2 participants