Clean up codegen export with quoted symbols #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fn - if - -> - ->>
genmeblog
reviewed
May 19, 2024
| (if (>= ~max-cols cols-count#) | ||
| (apply ~fn-sym (apply vector selected-cols#)) | ||
| (throw (Exception. (str "Exceeded maximum number of columns allowed for operation."))))))] | ||
| (~'if (>= ~max-cols cols-count#) |
genmeblog
reviewed
May 19, 2024
| (->> args-to-pass# | ||
| (apply ~fn-sym) | ||
| args-to-pass# (~'concat selected-cols# [~@(drop 3 args)])] | ||
| (~'if (>= ~max-cols (~'count selected-cols#)) |
genmeblog
reviewed
May 19, 2024
| (fn [ds#] | ||
| (~let [ds-with-selected-cols# | ||
| (~'let [aggregator# | ||
| (~'fn [ds#] |
There was a problem hiding this comment.
ds# -> ~'ds - it will generate more clean code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
@joinr pointed out that the Column API MVP merged in #100 had codegen that exported many qualified symbols, which made the generated functions a little bit messier than they need to be.
Also in this PR
A small fix to the docstrings in
tablecloth.api.operators. See this diff: https://github.com/scicloj/tablecloth/pull/151/files#diff-079771ab2c8ad3559f9e8c2b23758b662d9062bb2f32a2cf61013595a2c4da93L42-L51