Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: move variables to objects and improve settings #13

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

marwinbaumannsbp
Copy link
Collaborator

@marwinbaumannsbp marwinbaumannsbp commented Aug 4, 2023

Behaviour

  • Timeouts of the suppressor lambdas have been increased to 120 seconds. The current timeout of 60 seconds is not always enough to process 100 records of findings.
  • The create_servicenow_access_keys variable, now called servicenow_integration.create_access_keys was not used in the code and therefore the default behaviour was that access keys would be created. This issue has been resolved.
  • The create_allow_all_egress_rule variable has been set to false.
  • The tags variable is now optional.

Variables

The following variables have been replaced by a new variable jira_integration:

  • jira_exclude_account_filter -> jira_integration.exclude_account_ids
  • jira_finding_severity_normalized -> jira_integration.finding_severity_normalized_threshold
  • jira_integration -> jira_integration.enabled
  • jira_issue_type -> jira_integration.issue_type
  • jira_project_key -> jira_integration.project_key
  • jira_secret_arn -> jira_integration.credentials_secret_arn
  • lambda_jira_name -> jira_integration.lambda_settings.name
  • lambda_jira_iam_role_name -> jira_integration.lambda_settings.iam_role_name
  • Additionally you are now able to specify the log_level, memory_size, and timeout of the lambda.

The following variables have been replaced by a new variable servicenow_integration:

  • servicenow_integration -> servicenow_integration.enabled
  • create_servicenow_access_keys -> servicenow_integration.create_access_keys

The following variables have been replaced by a new variable lambda_events_suppressor:

  • lambda_events_suppressor_name -> lambda_events_suppressor.name
  • Additionally you are now able to specify the log_level, memory_size, and timeout of the lambda.

The following variables have been replaced by a new variable lambda_streams_suppressor:

  • lambda_streams_suppressor_name -> lambda_streams_suppressor.name
  • Additionally you are now able to specify the log_level, memory_size, and timeout of the lambda.

@marwinbaumannsbp marwinbaumannsbp changed the title Breaking: move variables to objects and improve settings breaking: move variables to objects and improve settings Aug 4, 2023
@marwinbaumannsbp marwinbaumannsbp marked this pull request as draft August 4, 2023 14:36
@github-actions github-actions bot added the breaking This change is not backwards compatible label Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


@marwinbaumannsbp marwinbaumannsbp force-pushed the improve-vars branch 13 times, most recently from 969811d to 6906682 Compare August 8, 2023 12:12
@marwinbaumannsbp marwinbaumannsbp marked this pull request as ready for review August 8, 2023 12:12
@marwinbaumannsbp marwinbaumannsbp added the documentation Improvements or additions to documentation label Aug 8, 2023
@marwinbaumannsbp marwinbaumannsbp merged commit 8cd8cf6 into main Aug 14, 2023
@marwinbaumannsbp marwinbaumannsbp deleted the improve-vars branch August 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change is not backwards compatible documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants