breaking: move variables to objects and improve settings #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour
create_servicenow_access_keys
variable, now calledservicenow_integration.create_access_keys
was not used in the code and therefore the default behaviour was that access keys would be created. This issue has been resolved.create_allow_all_egress_rule
variable has been set tofalse
.tags
variable is now optional.Variables
The following variables have been replaced by a new variable
jira_integration
:jira_exclude_account_filter
->jira_integration.exclude_account_ids
jira_finding_severity_normalized
->jira_integration.finding_severity_normalized_threshold
jira_integration
->jira_integration.enabled
jira_issue_type
->jira_integration.issue_type
jira_project_key
->jira_integration.project_key
jira_secret_arn
->jira_integration.credentials_secret_arn
lambda_jira_name
->jira_integration.lambda_settings.name
lambda_jira_iam_role_name
->jira_integration.lambda_settings.iam_role_name
log_level
,memory_size,
andtimeout
of the lambda.The following variables have been replaced by a new variable
servicenow_integration
:servicenow_integration
->servicenow_integration.enabled
create_servicenow_access_keys
->servicenow_integration.create_access_keys
The following variables have been replaced by a new variable
lambda_events_suppressor
:lambda_events_suppressor_name
->lambda_events_suppressor.name
log_level
,memory_size,
andtimeout
of the lambda.The following variables have been replaced by a new variable
lambda_streams_suppressor
:lambda_streams_suppressor_name
->lambda_streams_suppressor.name
log_level
,memory_size,
andtimeout
of the lambda.