Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support imported array shapes (@phpstan-import-type) #1551

Merged
merged 2 commits into from
Jul 22, 2024
Merged

feat: support imported array shapes (@phpstan-import-type) #1551

merged 2 commits into from
Jul 22, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jul 19, 2024

Q A
Bug fix? no
New feature? yes
Doc updated "yes"
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets Resolves #1547
License MIT

Includes #1548

@simPod simPod changed the title Type import from feat: support imported array shapes (@phpstan-import-type) Jul 19, 2024
@simPod simPod force-pushed the type-import-from branch 2 times, most recently from 3420d2a to 0190dfc Compare July 19, 2024 11:29
scyzoryck
scyzoryck approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@scyzoryck scyzoryck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simPod the code looks good. Please see comment from #1548 :)

@scyzoryck scyzoryck merged commit 58b8f72 into schmittjoh:master Jul 22, 2024
14 of 18 checks passed
@simPod simPod deleted the type-import-from branch July 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scyzoryck scyzoryck scyzoryck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support @phpstan-import-type
2 participants
@simPod @scyzoryck