Fix named parameter used for trans filter

[Steveb-p]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes/no
Fixed tickets
License	Apache2

Description

This PR allows TwigExtractor to recognize a following case:

{{ 'Some text that belongs to another translation domain'|trans(domain='not_messages_domain') }}

I'd love to have this in 1.x series (since I still have projects that depend on them), but I don't know if it's still under maintenance.

Could you point me to relevant tests to add a case for them?

Todos

• Tests
• Documentation
• Changelog

[goetas]

Hi, thanks for your contribution. Could you please fix the failing tests?

[Steveb-p]

@goetas I've updated the CI to use nikic/php-parser ^4.9. simple-phpunit installed v5 without additional instructions, causing PHP fatal error.

See symfony/symfony#53459 (comment) as the source of the workaround.

[Steveb-p]

@goetas I've run tests on my fork (https://github.com/Steveb-p/JMSTranslationBundle/actions/runs/10504385228) to ensure they will actually pass on GitHub actions.

I've moved those changes to #589 so they can be viewed separately. Once that is confirmed, I'll drop those commits from here.

[goetas]

Thanks

[Steveb-p]

Are you okay with merging this (and resolving any conflicts) into master, or should I provide a PR for you? :)

[goetas]

It would be great if you could do it

[goetas]

🙏

[goetas]

I guess that you need a new tag right?

[Steveb-p]

Yeah, I'd be grateful for a release in the near future :) but no rush, whenever you have some spare time 🙏 🙇

[Steveb-p]

Merge is available in #590.

phpunit.xml changes are "ignored", as they are not needed on the master branch.