Allow skipping dirs validation during configuration warmup #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to validate the dirs until we actually run the extraction. This PR adds the validate_dir option which defaults to `true` so users can opt for not validating the dirs paths during configuration warmup phase. It's possible that we still want to do validation at extract phase and we can add the code to do that if it is necessary.
|
What is the use case for this? Why does it matter when the validation occurs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new config key to allow skipping the dirs validation during configuration phase
Todos
There is no reason to validate the dirs until we actually run the
extraction. This PR adds the validate_dir option which defaults to
trueso users can opt for not validating the dirs paths duringconfiguration warmup phase.
It's possible that we still want to do validation at extract phase
and we can add the code to do that if it is necessary.