Default Symfony xliff dumper should be used instead of JMS #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will get a 👎 from me. It is a BC break since we remove the metadata about where the translations exists. That metadata is however only used in the WebUI and I understand that many users do not use the WebUI at all but as long as the WebUI is a part of this bundle we should not merge this PR. A discussion about splitting the bundle into smaller parts is started here: #283 |
|
We should of course make this optional by the bundle's configuration. That way we let the user to choose the dumper. If we do not alter the default behavior, Im happy to merge a change like this. jms_translation:
dumper: 'service_id_for_a_dumper'There is one more issue to solve (I think). It's how we use different dumpers for different filetypes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are using the XLIFF dumper made in JMSTranslationBundle with the extractor.
We should be using the XliffFileDumper from Symfony for all the default extraction.
Todos