-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert project to dotnet 8 and add github actions #6
base: master
Are you sure you want to change the base?
Conversation
Converted project to dotnet 8 Added github Actions
Hi there Personally I think every additional dependency to a piece of software needs to be warranted with good technical reasons. If for example Windows 11 (or 12) were to drop compatibility with .NET Framework 4.5 we would have a good reason, but as far as I know that is not the case. Another issue with newer dotnet versions is that I can't build or test it because I use Visual Studio 2013. Is there anything that dotnet8 fixes what is currently broken? I do like adding github actions, but that alone does not warrant upgrading the runtime, especially for a project with so few commits. |
No problem :) |
That is interesting with running natively on non-Windows operating systems. I did not know this. I could maybe see us keeping the code compatible with both 4.5 and something newer so we can keep the current 200 kb EXE for Windows and then maybe something bigger built by CI that runs natively on other OSes. And also so I can keep using Visual Studio 2013 :-) |
No idea how big the package gets. It believe it will depend on the actual dependencies of the app. |
I tried to run the output of the GitHub Action on your repository but all I get is a popup that says this:
This is what I want to avoid by targeting an older, wider supported runtime. Also generally I like to keep distribution light not only on file size but also on the number of files. Currently we have a single EXE file that runs on Windows 8 and upwards with no need to install anything. It runs on Windows XP to Windows 7 by installing the dotnet 4.5 runtime and on Linux by installing Mono and Mono-Winforms. If we can run on Windows 7 and older without the need to install anything and on Linux and Mac also with a lighter dependency than Mono, then that would be a win, if it can be achieved without bloating the download too much. |
Indeed, the current CI doesn't publish the app with dependencies included, (but it seems to be possible), this is why it's asking you to install the runtime. |
Thank you for making this very useful tool
I hope you'll find this PR useful
Converted project to dotnet 8
Added github actions for basic CI