scx_layered: fix kprobe race #3132
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently attach kprobes along with the rest of the BPF programs in the scx_layered skeleton, but that can lead to the kprobes being attached before the struct_ops of the scheduler itself. This in turns introduces a window of time during which tasks that use the GPU may trigger the krpobes and attempt to retrieve their task context, before said context is created in .init(). This in turn causes spurious lookup failures that falsely imply the kprobe logic is flawed and prevents us from putting in checks to catch any actual latent bugs.
Defer kprobe attach until after the rest of the progs in the skeleton are ready. First, introduce a variant of the kprobe_enable function in scx_utils that allows the kprobe to be loaded but not attached. Then, modify scx_layered to only trigger kprobe attach after the scheduler is up-and-running.