Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OHLC test #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

juancarlosqr
Copy link

@juancarlosqr juancarlosqr commented Oct 22, 2020

Changes

  • Resolves OHLC test failing #34:
    • For some reason calling the OHLC endpoint with AAPL returns empty data but for T it doesn't. I guess it might be because they are in different exchanges and/or as the docs describes:

Some stocks can report late open or close prices

Notes

Hi @schardtbc! I'm adding this as part of the Hacktoberfest effort 🍻🥨. In order for this PR to be accepted for the Hacktoberfest you would have to add the designated label:

An individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

If you can do that, I would highly appreciate it! 🤞🏼 Thanks

@juancarlosqr
Copy link
Author

@schardtbc You got a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OHLC test failing
1 participant