Skip to content

Better menus, worker queue, branch deletion, multi selection #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

smlpt
Copy link
Collaborator

@smlpt smlpt commented May 28, 2025

This PR adds the following new features:

  • branch deletion by holding the delete button for 0.5s
  • multi selection: simply click another sphere to add it to the selection. Dragging with the selection button allows you to quickly "paint" a selection. Clicking away will remove the selection
  • Graph changes are now handled asynchronously through a worker queue that locks mastodon's graph while editing

Fixed:

  • timepoint wrapping between TP 0 and maximum TP
  • always include the whole time range for NN linking
  • unified the start/stop VR buttons into a single button to prevent state issues
  • Track merging is now handled more robustly
  • Fixed polarity of tracks that are sent to Mastodon
  • Fixed spot radius representation in sciview by calculating the geometric mean for each spot. This maintains the same volume for spheres in sciview even if the mastodon spot has an ellipse shape (and we currently don't support ellipses due to a weird issue in representing the rotation)

@smlpt
Copy link
Collaborator Author

smlpt commented May 28, 2025

@skalarproduktraum due to lack of admin rights in the repo: please review :)

@smlpt smlpt requested a review from skalarproduktraum May 28, 2025 10:11
@smlpt
Copy link
Collaborator Author

smlpt commented May 28, 2025

The only aspect I'd like you check for the review would be whether I implemented the worker queue correctly.

@smlpt
Copy link
Collaborator Author

smlpt commented Jul 4, 2025

@skalarproduktraum I added a few minor bug fixes to this PR, but now its really ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant