Closed
Conversation
… the variable names.
…ast we don't get a big red X.
…ast we don't get a big red X.
…ion that installed non-flat header tree by transitive dependencies.
…ee artifacts and thus were masking installation issues
4f2d0da to
d613e91
Compare
…ion that installed non-flat header tree by transitive dependencies.
Initial support for Apple Frameworks Move scripts into subfolder Remove set(CMAKE_MACOSX_RPATH ON) because that is already the default value. Fix framework install directory when not installing to the system.
…d for Ubuntu 18.04 which we no longer support)
…(temporarily disabled non apple runners for debugging)
…is is top-level project.
…ion that installed non-flat header tree by transitive dependencies.
…d for Ubuntu 18.04 which we no longer support)
…(temporarily disabled non apple runners for debugging)
2eeae9d to
14ffd08
Compare
Contributor
Author
|
@cboulay It should now be updated, I just checked the diff and it looks good, no stray files anymore so there should be no conflicts merging to dev edit: that said you might want to squash merge because of the rebase adding me to all the commits for some reason |
Collaborator
|
See #258 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-do of #234 but from a dedicated branch and targeting
cboulay/apple_framework