Fix triggering replication when multiple destinations are set #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Kerkesni
force-pushed
the
bugfix/S3UTILS-184
branch
from
00a5b99 to
09ccadb
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_pull_requests |
- Issue 1: In Artesca "SITE_NAME" is never passed, so we always trigger objects that are replicated to the first storageClass in the replication rule. - Issue 2: We check the global replication status when verifying wether or not an object should be retriggered. This doesn't necessarily work all the time, especially when replicating to multiple destinations. As if one destination fails the global status becomes failed, which will make it impossible to trigger objects with a completed status for example. - Issue 3: replication info is completely overwritten when it does not contain info about a specific site. This will cause an issue when replicating to multiple destinations as the script can only be launched for one site at a time, so when having a object with non initialized replication info, we won't be able to set the replication info propely for all destinations. Issue: S3UTILS-184
Kerkesni
force-pushed
the
bugfix/S3UTILS-184
branch
from
09ccadb to
4efccfb
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_pull_requests |
| @@ -114,16 +114,19 @@ class ReplicationStatusUpdater { | |||
| * Determines if an object should be updated based on its replication metadata properties. | |||
| * @private | |||
| * @param {ObjectMD} objMD - The metadata of the object. | |||
| * @param {string} storageClass - The storage class for replication. | |||
There was a problem hiding this comment.
location or site ?
the storageClass is really just where the object is "locally" stored, not where we will copy/send it...
| if (!objMD.getReplicationInfo() | ||
| || !objMD.getReplicationSiteStatus(storageClass)) { | ||
| let replicationInfo = objMD.getReplicationInfo(); | ||
| if (!replicationInfo || !replicationInfo.status) { | ||
| const { Rules, Role } = repConfig; | ||
| const destination = Rules[0].Destination.Bucket; |
There was a problem hiding this comment.
this may not be correct, if there is more than 1 desitination....
Comment on lines
+197
to
+199
| storageClass: '', | ||
| role: Role, | ||
| storageType: this.storageType, | ||
| storageType: '', |
There was a problem hiding this comment.
what are these 2 fields (storageClass and storageType) used for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: In Artesca "SITE_NAME" is never used, so we always
trigger objects that are replicated to the first storageClass in
the replication rule.
Issue 2: We check the global replication status when verifying
wether or not an object should be retriggered. This doesn't necessarily
work all the time, especially when replicating to multiple destinations.
As if one destination fails the global status becomes failed, which will
make it impossible to trigger objects with a completed status for example.
Issue 3: replication info is completely overwritten when it does not contain
info about a specific site. This will cause an issue when replicating to multiple
destinations as the script can only be launched for one site at a time, so when
having a object with non initialized replication info, we won't be able to set
the replication info properly for all destinations.
Issue: S3UTILS-184