feat(storcli2): top-level RAID controller composition adapter#73
Merged
Conversation
g-carre
force-pushed
the
feature/storcli2-blinker
branch
from
9c532af to
28550ac
Compare
g-carre
force-pushed
the
feature/storcli2-raidcontroller-composition
branch
from
326c95c to
0ade4e4
Compare
Contributor
|
LGTM — composition adapter correctly wires all seven storcli2 components behind ports.RAIDController, constructor signatures match, compile-time interface check is present, and the smoke test exercises the full wiring. No issues found. |
g-carre
force-pushed
the
feature/storcli2-blinker
branch
from
28550ac to
3be14c1
Compare
g-carre
force-pushed
the
feature/storcli2-raidcontroller-composition
branch
from
0ade4e4 to
0ae498e
Compare
Contributor
|
LGTM — composition correctly embeds all seven ports.RAIDController interfaces, shares the physicalDrivesGetter and logicalVolumesGetter instances with components that depend on them, and has a compile-time interface assertion plus a smoke test. No issues found. |
g-carre
force-pushed
the
feature/storcli2-blinker
branch
from
3be14c1 to
0c6c272
Compare
g-carre
force-pushed
the
feature/storcli2-raidcontroller-composition
branch
from
0ae498e to
0c6c272
Compare
Contributor
|
LGTM |
Add raidcontroller.StorCLI2, composing the storcli2 components into the full ports.RAIDController surface: - Embeds the controller / physical-drive / logical-volume getters, the logical-volume manager, the cache setter, the JBOD setter and the blinker. - The physical-drive getter doubles as the JBOD setter and the logical-volume manager doubles as the cache setter, so those components are shared rather than constructed twice. - storcli2 supports every operation, so there are no ErrFunctionNotSupportedByImplementation stubs (DeletePDsFromLV's unsupported error is returned by the logical-volume manager itself). - NewStorCLI2 wires everything on a single injected runner; the same composition serves both the storcli2 and perccli2 binaries. A smoke test wires the full adapter on a mocked runner, asserts it satisfies ports.RAIDController, and drives one operation end to end. Issue: ARTESCA-17651
The top-level raidcontroller.StorCLI2 composition is now in place, so the DESIGN.md note no longer describes it as future work. Clarify that DeletePDsFromLV's unsupported error comes from the logical-volume manager itself rather than a composition-level stub. Partially addresses the storcli2 adapter documentation; binary-selection and fixture-layout docs remain. Issue: ARTESCA-17654
…ment The note that storcli2 "can't remove drives" reads as if a failed drive could not be replaced. Clarify that what is unsupported is shrinking a volume's member set (storcli's `start migrate option=remove`); replacing a failed drive (rebuild / hot-spare / copyback) keeps the member count, is a separate command family storcli2 still exposes, and is out of scope for raidmgmt regardless of controller. Issue: ARTESCA-17654
g-carre
force-pushed
the
feature/storcli2-blinker
branch
from
fc6b402 to
a40039e
Compare
g-carre
force-pushed
the
feature/storcli2-raidcontroller-composition
branch
from
96db516 to
8c539d3
Compare
Contributor
|
LGTM — the composition correctly satisfies |
ezekiel-alexrod
approved these changes
Jul 1, 2026
Base automatically changed from
feature/storcli2-blinker
to
feature/storcli2-lv-manager-pd-membership
July 1, 2026 15:40
Base automatically changed from
feature/storcli2-lv-manager-pd-membership
to
feature/storcli2-lv-manager-create-delete
July 1, 2026 16:08
Base automatically changed from
feature/storcli2-lv-manager-create-delete
to
main
July 1, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the top-level
raidcontroller.StorCLI2composition adapter (ARTESCA-17651), the final piece of the decomposed storcli2/perccli2 adapter. Stacked on #72.ports.RAIDControllersurface: controller / physical-drive / logical-volume getters, logical-volume manager, cache setter, JBOD setter, blinker.JBODSetterand the logical-volume manager doubles as theLVCacheSetter, so those components are shared rather than constructed twice.ErrFunctionNotSupportedByImplementationstubs (unlike SmartArray);DeletePDsFromLV's unsupported error comes from the logical-volume manager itself.NewStorCLI2wires everything on a single injected runner — the same composition serves both the storcli2 and perccli2 binaries.Also updates the DESIGN.md note (separate commit, ARTESCA-17654) to mark the composition as implemented rather than future work.
Testing
go build,go vet,gofmt, and the full suite pass. A smoke test wires the full adapter on a mocked runner, asserts it satisfiesports.RAIDController, and drives one operation (StartBlink) end to end through the runner.Issue: ARTESCA-17651
🤖 Generated with Claude Code