Refactor chart components to utilize LineTimeSerieChart #4661

JeanMarcMilletScality · 2025-09-24T13:18:41Z

The goal of this PR is to replace line chart with new core-ui version
Include only the "simple" charts
The transformation data were not changed as they are also use by quantile chart

Next step: refactor the quantile chart and the data transformation fn to reflect new types for line chart

~~Still a draft as a new release of core-ui is needed~~

bert-e · 2025-09-24T13:18:44Z

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-09-24T13:18:52Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Add ts-ignore directivel: will be fix by refactor of quantile chart

…f the data received by the chart where Q5 and Q90 were reversed Improve metrics and utils fn typing, remove ts directives

clean debugging code

Create custom tooltip to allow fetching of data on hover

Improve typing

…ver fetching logic and ensure proper handling of quantile data. Update shared tooltip transformation to handle null values more gracefully. Adjust graphUtils to use constants for cluster average and clean up unused code.

…s and clean up code for better readability.

…chart components

ChengYanJin

LGTM !

ChengYanJin · 2025-10-01T12:36:49Z

/create_integration_branches

bert-e · 2025-10-01T12:36:58Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/replace-line-chart into
development/131.0
w/132.0/improvement/replace-line-chart will be merged into development/132.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/129.0
development/130.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-10-01T12:36:59Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: create_integration_branches

… use register instead of direclty defining colorSet for ChartLegend

…defined

…rt and SymmetricalQuantileChart to remove duplicate calculation

Improvement/replace quantile chart

bert-e · 2025-10-03T08:45:23Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: create_integration_branches

Refactor chart components to utilize LineTimeSerieChart

be67551

JeanMarcMilletScality added 3 commits September 24, 2025 15:26

Remove unused ts directive

c14d6f2

Add ts-ignore directivel: will be fix by refactor of quantile chart

update core-ui to version 0.171.0

77a0cd0

WIP quantile chart migration - Quantile Q05>Q90 bug exploration

7a0a2de

JeanMarcMilletScality marked this pull request as ready for review September 30, 2025 08:05

JeanMarcMilletScality requested a review from a team as a code owner September 30, 2025 08:05

JeanMarcMilletScality added 10 commits September 30, 2025 16:53

Add sorting fn and add it to quantile queries: this fix the sorting o…

b54a20c

…f the data received by the chart where Q5 and Q90 were reversed Improve metrics and utils fn typing, remove ts directives

Use constants for height and color values

96476ac

clean debugging code

Migrate quantile chart to new linetimeseries chart

b9283a8

Create custom tooltip to allow fetching of data on hover

update graphUtils test

00f1666

Add color for Cluster average in metrics for node

8233fd6

Improve typing

Improve type safety and remove unnecessary TypeScript error directive…

5da3160

…s and clean up code for better readability.

Remove testing code

ad0372c

Remove TypeScript error directives from CPU, Memory, and System Load …

f00f5f2

…chart components

Use constants for height values for charts for better consistency.

8fc2960

ChengYanJin previously approved these changes Oct 1, 2025

View reviewed changes

JeanMarcMilletScality and others added 4 commits October 1, 2025 18:31

Refactor chart components to use custom hook for legend registration.…

783b056

… use register instead of direclty defining colorSet for ChartLegend

fix usechartlegendregistration hook: error when additionalNames is un…

c5568c4

…defined

Refactor unit base and label calculation in NonSymmetricalQuantileCha…

b6c0791

…rt and SymmetricalQuantileChart to remove duplicate calculation

Merge pull request #4663 from scality/improvement/replace-quantile-chart

4a86d46

Improvement/replace quantile chart

JeanMarcMilletScality dismissed ChengYanJin’s stale review via 4a86d46 October 3, 2025 08:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor chart components to utilize LineTimeSerieChart #4661

Refactor chart components to utilize LineTimeSerieChart #4661

Uh oh!

JeanMarcMilletScality commented Sep 24, 2025 •

edited

Loading

Uh oh!

bert-e commented Sep 24, 2025

Uh oh!

bert-e commented Sep 24, 2025

Uh oh!

ChengYanJin left a comment

Uh oh!

ChengYanJin commented Oct 1, 2025

Uh oh!

bert-e commented Oct 1, 2025

Uh oh!

bert-e commented Oct 1, 2025

Uh oh!

bert-e commented Oct 3, 2025

Uh oh!

Uh oh!

Refactor chart components to utilize LineTimeSerieChart #4661

Are you sure you want to change the base?

Refactor chart components to utilize LineTimeSerieChart #4661

Uh oh!

Conversation

JeanMarcMilletScality commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Sep 24, 2025

Hello jeanmarcmilletscality,

Uh oh!

bert-e commented Sep 24, 2025

Request integration branches

Uh oh!

ChengYanJin left a comment

Choose a reason for hiding this comment

Uh oh!

ChengYanJin commented Oct 1, 2025

Uh oh!

bert-e commented Oct 1, 2025

Integration data created

Uh oh!

bert-e commented Oct 1, 2025

Waiting for approval

Uh oh!

bert-e commented Oct 3, 2025

Waiting for approval

Uh oh!

Uh oh!

JeanMarcMilletScality commented Sep 24, 2025 •

edited

Loading