MK8S-25: Disable HTTP directory listing for RPM repository #4651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello rdebay-scality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
rdebay-scality
force-pushed
the
bugfix/MK8S-25-disable-http-directory-listing
branch
2 times, most recently
from
9f7f5e0 to
1825521
Compare
rdebay-scality
force-pushed
the
bugfix/MK8S-25-disable-http-directory-listing
branch
2 times, most recently
from
3bb0469 to
852d918
Compare
rdebay-scality
commented
Sep 23, 2025
Comment on lines
304
to
312
| targets.extend( | ||
| [ | ||
| # Repository-level saltenv structure | ||
| saltenv_dir / "index.html", | ||
| saltenv_dir / "redhat" / "index.html", | ||
| saltenv_dir / "redhat" / str(self._releasever) / "index.html", | ||
| # Top-level saltenv (for health check) | ||
| top_saltenv_dir / "index.html", | ||
| ] |
There was a problem hiding this comment.
This creation should be factorized.
rdebay-scality
force-pushed
the
bugfix/MK8S-25-disable-http-directory-listing
branch
from
25dbb07 to
191132f
Compare
Security fix to prevent exposing repository structure on port 8080. - Changed autoindex from on to off in nginx configuration. - Use nginx location directives to return 200 for health checks instead of index files This maintains the original health check functionality while preventing directory structure exposure. The nginx location = / and location = /saltenv/ directives handle health check requests with 200 status, while location / handles all other requests with autoindex off for security. The nginx.conf.j2 template uses the archives variable to generate location directives for each saltenv, but the variable wasn't being passed in the template context. This caused Salt unit tests to fail. The creation of index.html files was tried but it creates a chicken and egg issue during the container startup when the files were not present. Plus this approach is much more simple, no code, not so much salt, only plain configuration. Related: RD-680
rdebay-scality
force-pushed
the
bugfix/MK8S-25-disable-http-directory-listing
branch
from
09e715b to
5ff8f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security fix to prevent exposing repository structure on port 8080. Changed autoindex from on to off in nginx configuration.
Related: RD-680