migrate shell-ui and metalk8s-ui to rspack #4347

MonPote · 2024-06-19T14:49:14Z

Component:

Context:

Summary:

Acceptance criteria:

Closes: #ISSUE_NUMBER

bert-e · 2024-06-19T14:49:18Z

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-06-19T14:49:24Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-20T14:18:57Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-20T15:54:35Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-21T09:41:42Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-21T21:00:06Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-27T13:59:42Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-28T14:38:29Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-07-01T13:13:15Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-07-02T14:44:30Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

GlobalHealthBar import cause issue when we laod metalk8s as a microapp. It's because the chunk are not in the same file as SyncedCursorCharts.

bert-e · 2024-07-18T15:40:37Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

We should invest some time to fix these type issue. We most probably need to change some of our React.ReactNode to JSX.Element. Most of type errors are related to this.

MonPote · 2024-07-19T09:41:14Z

/approve

bert-e · 2024-07-19T09:41:22Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2024-07-19T15:21:29Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/128.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2024-07-19T17:53:38Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/128.0

The following branches have NOT changed:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye monpote.

MonPote force-pushed the feature/migrate-to-rspack branch from 15b1b6a to f6abedc Compare June 21, 2024 16:27

MonPote force-pushed the feature/migrate-to-rspack branch from 386df86 to c6947b8 Compare June 28, 2024 15:37

MonPote added 18 commits July 3, 2024 15:58

update package to be ready for node 20

1ad1ec9

install and build with rspack

ced34bf

install and build with rspack metalk8s-ui

a3ee7a0

shell is running alone

c5234ce

add module federation enhanced to shell

2ab356d

add module federation enhanced to metalk8s

f0d7672

SAVE TMPModuleFederation.tsx

2aa5b28

improve fetching of manifest

c8de275

remove legacy files

989a580

update shell-ui html template to use mf-manifest instead of remoteEntry

383c555

update module federation to 1.3.0

ea76c50

update rspack config and change manifest url

58367a6

add federated type in the gitignore

8b1222e

remove legacy files

1e3cb45

some cleaning rspack.config.ts

44a9798

fix jest tests

4ab6047

fix jest tests

47e0316

fix docker build

205a890

MonPote and others added 8 commits July 11, 2024 12:11

fix GlobalHealthBar import

b007a1f

GlobalHealthBar import cause issue when we laod metalk8s as a microapp. It's because the chunk are not in the same file as SyncedCursorCharts.

update mf-types

c706d87

remove the need to load all microapp for NavbarUpdaterComponents

f3e27e7

update dockerfile node version

13e1def

update core-ui

1dcd9e6

Fix firefox routing issue

39962bc

fix redux store type

9fd0873

update mf-types

eb24aa1

MonPote changed the title ~~update package to be ready for node 20~~ migrate shell-ui and metalk8s-ui to rspack Jul 18, 2024

Merge remote-tracking branch 'origin/development/128.0' into HEAD

c9e45bb

fix unit test

3f37f4f

MonPote marked this pull request as ready for review July 18, 2024 17:07

MonPote requested a review from a team as a code owner July 18, 2024 17:07

MonPote force-pushed the feature/migrate-to-rspack branch 2 times, most recently from 81151fc to 0527c37 Compare July 18, 2024 17:24

run rsbuild instead of build to avoid the type checking

f2c5cb2

We should invest some time to fix these type issue. We most probably need to change some of our React.ReactNode to JSX.Element. Most of type errors are related to this.

MonPote force-pushed the feature/migrate-to-rspack branch from 0527c37 to f2c5cb2 Compare July 19, 2024 01:45

Remove useless useEffect

a5fe5c4

JBWatenbergScality previously approved these changes Jul 19, 2024

View reviewed changes

Fix end2end tests

cf3d7f1

JBWatenbergScality dismissed their stale review via cf3d7f1 July 19, 2024 08:58

Fix end2end tests

147e2e8

JBWatenbergScality approved these changes Jul 19, 2024

View reviewed changes

bert-e merged commit feb8dfc into development/128.0 Jul 19, 2024
26 checks passed

bert-e deleted the feature/migrate-to-rspack branch July 19, 2024 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate shell-ui and metalk8s-ui to rspack #4347

migrate shell-ui and metalk8s-ui to rspack #4347

MonPote commented Jun 19, 2024

bert-e commented Jun 19, 2024

bert-e commented Jun 19, 2024

bert-e commented Jun 20, 2024

bert-e commented Jun 20, 2024

bert-e commented Jun 21, 2024

bert-e commented Jun 21, 2024

bert-e commented Jun 27, 2024

bert-e commented Jun 28, 2024

bert-e commented Jul 1, 2024

bert-e commented Jul 2, 2024

bert-e commented Jul 18, 2024

MonPote commented Jul 19, 2024

bert-e commented Jul 19, 2024

bert-e commented Jul 19, 2024

bert-e commented Jul 19, 2024

migrate shell-ui and metalk8s-ui to rspack #4347

migrate shell-ui and metalk8s-ui to rspack #4347

Conversation

MonPote commented Jun 19, 2024

bert-e commented Jun 19, 2024

Hello monpote,

bert-e commented Jun 19, 2024

Waiting for approval

bert-e commented Jun 20, 2024

Waiting for approval

bert-e commented Jun 20, 2024

Waiting for approval

bert-e commented Jun 21, 2024

Waiting for approval

bert-e commented Jun 21, 2024

Waiting for approval

bert-e commented Jun 27, 2024

Waiting for approval

bert-e commented Jun 28, 2024

Waiting for approval

bert-e commented Jul 1, 2024

Waiting for approval

bert-e commented Jul 2, 2024

Waiting for approval

bert-e commented Jul 18, 2024

Waiting for approval

MonPote commented Jul 19, 2024

bert-e commented Jul 19, 2024

Waiting for approval

bert-e commented Jul 19, 2024

In the queue

bert-e commented Jul 19, 2024