Skip to content

ARTESCA-14587: new line time serie chart component #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: development/1.0
Choose a base branch
from
Open

ARTESCA-14587: new line time serie chart component #817

wants to merge 5 commits into from

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Mar 5, 2025 •
edited
Loading

Component:
linetimeseriechart

Description:

Design:
Percentage chart:
image

Symmetrical chart:
image

Adjust the unit base on the rawdata
image

@bert-e
Copy link
Contributor

bert-e commented Mar 5, 2025

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 5, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin changed the title ARTESCA-14587: new line chart component ARTESCA-14587: new line time serie chart component Mar 5, 2025
@ChengYanJin ChengYanJin force-pushed the feature/ARTESCA-14587-new-line-chart-component branch from eebaf4b to 4bc8060 Compare March 5, 2025 16:41
@ChengYanJin ChengYanJin marked this pull request as ready for review March 5, 2025 16:53
@ChengYanJin ChengYanJin force-pushed the feature/ARTESCA-14587-new-line-chart-component branch from 4bc8060 to 6c35a0b Compare March 5, 2025 16:59
JBWatenbergScality
JBWatenbergScality reviewed Mar 5, 2025
View reviewed changes
src/lib/components/linetimeseriechart/linetimeseriechart.component.tsx Outdated

// Assign colors to unique resources
Object.keys(groups).forEach((resource, index) => {
const color = colorRange[index % colorRange.length];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the issue of one chart missing one serie and messing the colors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will address this issue through context in the following PR.

@bert-e
Copy link
Contributor

bert-e commented Mar 6, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Mar 7, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the feature/ARTESCA-14587-new-line-chart-component branch from 3e2c58f to c7e5da5 Compare March 7, 2025 15:01
@bert-e
Copy link
Contributor

bert-e commented Mar 7, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the feature/ARTESCA-14587-new-line-chart-component branch from c7e5da5 to 3b88417 Compare March 10, 2025 10:36
@bert-e
Copy link
Contributor

bert-e commented Mar 10, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengYanJin @bert-e @JBWatenbergScality